Refactor of HttpSender implementations with Factory Pattern (1/2) #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- refactor Http senders to expose a factory `HttpSenderFactory` and provide an implementation according to the configuration - Use abstraction `AbstractHttpSender` for sending message and sending with retry - Every Http request is handled by a `HttpSender` implementation, even retrieving an access token with `AccessTokenHttpSender` - Each `HttpSender` implementation creates its own `HttpRequestBuilder` with separate responsibilities - Add Code coverage on `sender` package to test the HttpRequest configuration
aprodhomme-dkt
changed the title
aprodhomme-dkt
changed the title
jeqo
requested changes
Jul 5, 2023
There was a problem hiding this comment.
Some comments on the main implementation. Will look into the tests a bit later.
Thanks @aprodhomme-dkt !
src/main/java/io/aiven/kafka/connect/http/recordsender/BatchRecordSender.java
Outdated
Show resolved
Hide resolved
src/test/java/io/aiven/kafka/connect/http/config/HttpSinkConfigTest.java
Outdated
Show resolved
Hide resolved
src/main/java/io/aiven/kafka/connect/http/sender/HttpSenderFactory.java
Outdated
Show resolved
Hide resolved
src/main/java/io/aiven/kafka/connect/http/sender/AccessTokenHttpSender.java
Outdated
Show resolved
Hide resolved
src/main/java/io/aiven/kafka/connect/http/sender/HttpSender.java
Outdated
Show resolved
Hide resolved
src/main/java/io/aiven/kafka/connect/http/sender/OAuth2HttpSender.java
Outdated
Show resolved
Hide resolved
src/main/java/io/aiven/kafka/connect/http/sender/AccessTokenHttpSender.java
Outdated
Show resolved
Hide resolved
src/main/java/io/aiven/kafka/connect/http/sender/AccessTokenHttpSender.java
Outdated
Show resolved
Hide resolved
src/main/java/io/aiven/kafka/connect/http/sender/AccessTokenHttpSender.java
Outdated
Show resolved
Hide resolved
src/main/java/io/aiven/kafka/connect/http/sender/AccessTokenHttpSender.java
Outdated
Show resolved
Hide resolved
jeqo
requested changes
Jul 13, 2023
src/main/java/io/aiven/kafka/connect/http/sender/AccessTokenHttpSender.java
Outdated
Show resolved
Hide resolved
src/main/java/io/aiven/kafka/connect/http/sender/OAuth2HttpSender.java
Outdated
Show resolved
Hide resolved
jeqo
reviewed
Jul 13, 2023
There was a problem hiding this comment.
@aprodhomme-dkt this is looking good! Thanks for helping me understand some of the changes.
I've added some additional comments on both PRs, mostly cosmetic.
jeqo
reviewed
Jul 26, 2023
There was a problem hiding this comment.
@aprodhomme-dkt thanks for applying most suggestions! I think there's a last missing nit to resolve; otherwise I'm happy to approve this PR.
Thanks again for the efforts here.
| @@ -26,9 +26,9 @@ interface HttpResponseHandler { | |||
|
|
|||
| Logger LOGGER = LoggerFactory.getLogger(HttpResponseHandler.class); | |||
|
|
|||
| void onResponse(final HttpResponse<String> response) throws IOException; | |||
| void onResponse(final HttpResponse<String> response, int retriesNumber) throws IOException; | |||
|
Here you go :) |
jeqo
requested changes
Jul 26, 2023
src/test/java/io/aiven/kafka/connect/http/sender/DefaultTokenHttpSenderTest.java
Outdated
Show resolved
Hide resolved
src/test/java/io/aiven/kafka/connect/http/sender/StaticTokenHttpSenderTest.java
Outdated
Show resolved
Hide resolved
|
@jeqo any news on those PRs? |
jjaakola-aiven
requested changes
Aug 3, 2023
src/test/java/io/aiven/kafka/connect/http/sender/HttpSenderTestUtils.java
Outdated
Show resolved
Hide resolved
src/main/java/io/aiven/kafka/connect/http/sender/AbstractHttpSender.java
Outdated
Show resolved
Hide resolved
jeqo
previously approved these changes
Aug 8, 2023
There was a problem hiding this comment.
@aprodhomme-dkt thanks for this contribution! I'm preemptively approving this, and we can merge it once Jaarkko's suggestions are resolved.
# Conflicts: # src/main/java/io/aiven/kafka/connect/http/HttpSinkTask.java
|
Hi @jeqo and @jjaakola-aiven, thanks for your reviews. I have just took into account your last comments. |
jjaakola-aiven
approved these changes
Aug 29, 2023
jeqo
approved these changes
Aug 29, 2023
|
Thanks, @aprodhomme-dkt! Let's have a look at #172 to wrap up this contribution 🙌🏽 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to have clearer responsibilities between the multiple HttpSender implementations. This is required to increase code coverage before introducing a new way to retrieve an access token (see 2nd PR: #172)
Changes:
HttpSenderFactoryand provide an implementation according to the configurationAbstractHttpSenderfor sending message and sending with retryHttpSenderimplementation, even retrieving an access token withAccessTokenHttpSenderHttpSenderimplementation creates its ownHttpRequestBuilderwith separate responsibilitiesThis refactor allows to test the HttpRequest that is sent to the API publisher and it covers all scenarios depending on the configuration.