added gd-translate command

[NicolasNewman]

I've implemented this command for my own use but you are more then welcome to merge it upstream.

Feature:

• Added command gd-translate
  • gd-translate --sentence %GDSEARCH%
  • gd-translate --spoiler yes --to fr --sentence %GDSEARCH%
• Powered by Argos Translate (MIT license) which can be installed and ran locally with pip

Usage:

usage: gd-translate [OPTIONS]

Translate text from Japanese to target language

OPTIONS
        --to LANG             target language (default: en)
  --sentence SENTENCE         japanese sentence to translate
   --spoiler yes/no           black out the sentence with a spoiler box (default: no)

EXAMPLES
  gd-translate --spoiler yes --sentence %GDSEARCH%
  gd-translate --spoiler yes --to fr --sentence %GDSEARCH%

Example:
With --spoiler yes

On hover (or without --spoiler yes):

[tatsumoto-ren]

Hello! Thanks for the PR!

I think that launching a process and redirecting its output to a file and then reading that file is too complicated. It would be much easier to launch a subprocess and capture its stdout directly. Additionally, passing the command as a string is error-prone because even if the arguments are escaped with quotes, I can break the command if my input contains quotes too.

[NicolasNewman]

What would you recommend I use for making sub processes? I also saw there was popen but that's Unix specific and still takes a string as a command.

[tatsumoto-ren]

There are many libraries that implement subprocess. For example, this one https://github.com/arun11299/cpp-subprocess.

Usage example:

#include <string>
#include <print>
#include <subprocess.hpp>

namespace sp = subprocess;

int main() {
  try {
    auto const obuf = sp::check_output({ "ls", "-la" });
    auto const output = std::string(obuf.buf.data(), obuf.length);
    std::println("output: {}", output);
  } catch (std::runtime_error const &e) {
    std::println("error: {}", e.what());
  }
}

[tatsumoto-ren]

There's no need to add this file to the project. Just include it as a dependency using xmake.

[tatsumoto-ren]

The string may not be null-terminated.

[tatsumoto-ren]

You're not catching the exceptions that may be thrown by cpp-subprocess.

[tatsumoto-ren]

I've removed tail -n1.

I'll merge if everything is working for you.

[NicolasNewman]

Everything looks good locally! Thanks for the help in fixing those issues.