[OGUI-1596] Update grpcErrorToNativeError to provide option for developer to use either message or details #2711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use details instead of message field of the gRPC error struct
graduta
changed the title
pepijndik
reviewed
Jan 8, 2025
graduta
changed the title
pepijndik
previously approved these changes
Jan 8, 2025
graduta
deleted the
improv/WEB/use-details-instead-of-message-in-grpc-error
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I DON'T have JIRA ticket
PR which:
detailsormessagefor the custom error classmessageincludes also the error key and code which is not needed as the custom error class already describes that but it might be useful to developers