Skip to content

Commit

Permalink
Fix mysql images release (#3738)
Browse files Browse the repository at this point in the history
  • Loading branch information
carlesarnal authored Oct 3, 2023
1 parent e7b7888 commit 89b334d
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
4 changes: 2 additions & 2 deletions .github/scripts/build-and-push-multiarch-images.sh
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,9 @@ RELEASE_TYPE="$4" # Either 'snapshot' or 'release' or 'pre-release'
RELEASE_VERSION=${5:-$defvalue} # Release version (Pass the release version if you also want images tagged with the release version)

# Check if variant type is valid
if [[ ($VARIANT != "mem-multiarch-images") && ($VARIANT != "sql-multiarch-images") && ($VARIANT != "kafkasql-multiarch-images") && ($VARIANT != "multiarch-registry-images") ]]
if [[ ($VARIANT != "mem-multiarch-images") && ($VARIANT != "sql-multiarch-images") && ($VARIANT != "kafkasql-multiarch-images") && ($VARIANT != "multiarch-registry-images") && ($VARIANT != "mysql-multiarch-images") ]]
then
echo "ERROR: Illegal value '${VARIANT}' for variable '$VARIANT'. Values can only be [mem-multiarch-images, sql-multiarch-images, kafkasql-multiarch-images, multiarch-registry-images]"
echo "ERROR: Illegal value '${VARIANT}' for variable '$VARIANT'. Values can only be [mem-multiarch-images, sql-multiarch-images, kafkasql-multiarch-images, multiarch-registry-images, mysql-multiarch-images]"
exit 1
fi

Expand Down
6 changes: 3 additions & 3 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -259,10 +259,10 @@ push-kafkasql-native-image:
docker push $(IMAGE_REPO)/apicurio/apicurio-registry-kafkasql-native:$(IMAGE_TAG)

.PHONY: build-all-images ## Builds all the Images. Variables available for override [IMAGE_REPO, IMAGE_TAG]
build-all-images: build-mem-image build-sql-image build-mssql-image build-kafkasql-image
build-all-images: build-mem-image build-sql-image build-mssql-image build-kafkasql-image build-mysql-image

.PHONY: push-all-images ## Pushes all the Images. Variables available for override [IMAGE_REPO, IMAGE_TAG]
push-all-images: push-mem-image push-sql-image push-mssql-image push-kafkasql-image
push-all-images: push-mem-image push-sql-image push-mssql-image push-kafkasql-image push-mysql-image


.PHONY: mem-multiarch-images ## Builds and pushes multi-arch images for 'in-memory' storage variant. Variables available for override [MEM_DOCKERFILE, IMAGE_REPO, IMAGE_TAG, DOCKER_BUILD_WORKSPACE]
Expand Down Expand Up @@ -326,7 +326,7 @@ mem-native-scratch-image:
docker buildx build --push -f $(DOCKERFILE_LOCATION)/$(MEM_SCRATCH_DOCKERFILE) -t $(IMAGE_REPO)/apicurio/apicurio-registry-mem-native-scratch:$(IMAGE_TAG) --platform $(IMAGE_PLATFORMS) $(DOCKER_BUILD_WORKSPACE)

.PHONY: multiarch-registry-images ## Builds and pushes multi-arch registry images for all variants. Variables available for override [IMAGE_REPO, IMAGE_TAG]
multiarch-registry-images: mem-multiarch-images sql-multiarch-images mssql-multiarch-images kafkasql-multiarch-images
multiarch-registry-images: mem-multiarch-images sql-multiarch-images mssql-multiarch-images kafkasql-multiarch-images mysql-multiarch-images



Expand Down

0 comments on commit 89b334d

Please sign in to comment.