Fail fast in v3 when detecting a v2 DB (#4306)

Author: EricWittmann

app/src/main/java/io/apicurio/registry/storage/impl/sql/AbstractSqlRegistryStorage.java

@@ -280,6 +280,16 @@ private boolean isDatabaseCurrent(Handle handle) {
         log.info("Checking to see if the DB is up-to-date.");
         log.info("Build's DB version is {}", DB_VERSION);
         int version = this.getDatabaseVersion(handle);
+
+        // Fast-fail if we try to run Registry v3 against a v2 DB.
+        // TODO how to do this for kafkasql??
+        if (version < 100) {
+            String message = "[Apicurio Registry 3.x] Detected legacy 2.x database.  Automatic upgrade from 2.x to 3.x is not supported.  Please see documentation for migration instructions.";
+            log.error("--------------------------");
+            log.error(message);
+            log.error("--------------------------");
+            throw new RuntimeException(message);
+        }
         return version == DB_VERSION;
     }
 

app/src/main/resources/io/apicurio/registry/storage/impl/sql/db-version

@@ -1 +1 @@
-1
+100

app/src/main/resources/io/apicurio/registry/storage/impl/sql/h2.ddl

@@ -4,7 +4,7 @@
 
 CREATE TABLE apicurio (prop_name VARCHAR(255) NOT NULL, prop_value VARCHAR(255));
 ALTER TABLE apicurio ADD PRIMARY KEY (prop_name);
-INSERT INTO apicurio (prop_name, prop_value) VALUES ('db_version', 1);
+INSERT INTO apicurio (prop_name, prop_value) VALUES ('db_version', 100);
 
 CREATE TABLE sequences (name VARCHAR(32) NOT NULL, seq_value BIGINT NOT NULL);
 ALTER TABLE sequences ADD PRIMARY KEY (name);

app/src/main/resources/io/apicurio/registry/storage/impl/sql/mssql.ddl

@@ -4,7 +4,7 @@
 
 CREATE TABLE apicurio (prop_name NVARCHAR(255) NOT NULL, prop_value NVARCHAR(255));
 ALTER TABLE apicurio ADD PRIMARY KEY (prop_name);
-INSERT INTO apicurio (prop_name, prop_value) VALUES ('db_version', 1);
+INSERT INTO apicurio (prop_name, prop_value) VALUES ('db_version', 100);
 
 -- TODO: Different column name in h2
 CREATE TABLE sequences (name NVARCHAR(32) NOT NULL, value BIGINT NOT NULL);

app/src/main/resources/io/apicurio/registry/storage/impl/sql/postgresql.ddl

@@ -4,7 +4,7 @@
 
 CREATE TABLE apicurio (prop_name VARCHAR(255) NOT NULL, prop_value VARCHAR(255));
 ALTER TABLE apicurio ADD PRIMARY KEY (prop_name);
-INSERT INTO apicurio (prop_name, prop_value) VALUES ('db_version', 1);
+INSERT INTO apicurio (prop_name, prop_value) VALUES ('db_version', 100);
 
 -- TODO: Different column name in h2
 CREATE TABLE sequences (name VARCHAR(32) NOT NULL, value BIGINT NOT NULL);