Implement derefence proto #4272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for creating a pull request! Pinging @jsenko, @EricWittmann to respond or triage. |
carlesarnal
force-pushed
the
implement-derefence-proto
branch
from
5c3adbd to
6c5efc1
Compare
|
@EricWittmann I'm going to document the limitation I mentioned and this will be ready to merge. After some investigations, I'm not even sure if this is going to be possible. Note that, if no dereference happens, having references in separate packages is perfectly fine, I just haven't discovered a way to dereference messages with different packages in a single, meaningful object that can then be parsed to deserialize messages. |
carlesarnal
force-pushed
the
implement-derefence-proto
branch
2 times, most recently
from
3dc4e48 to
2e01069
Compare
carlesarnal
force-pushed
the
implement-derefence-proto
branch
from
2e01069 to
d9f38b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@EricWittmann this PR includes the same as #4256 but for protobuf. The biggest caveat is that, for now, it only works for dereferencing schemas that live under the same package.