Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Database] Switch to cascading deletes in the DB layer where possible + some cleanup #4312

Merged
merged 6 commits into from
Feb 13, 2024

Conversation

EricWittmann
Copy link
Member

This PR includes the following DB changes:

  • Add ON DELETE CASCADE where appropriate to FKs
  • Add FK from artifact_branches to artifacts table
  • Rename globalrules to global_rules
  • Rename rules table to artifact_rules
  • Rename artifactreferences table to content_references
  • Rename artifactreferences column on content table to refs
  • Rename comments table to version_comments
  • Organize/group table definitions within DDL file
  • Create new group_rules table (future need)
  • Standardize on seq_name and seq_value for column names in sequences table
  • Reduce max label value column size to 512
  • Add INDEX on label value columns for mssql DB flavor

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Copy link

github-actions bot commented Feb 8, 2024

Qodana Community for JVM

31 new problems were found

Inspection name Severity Problems
Unnecessary modifier 🔶 Warning 18
Overly complex class 🔶 Warning 3
Class with too many methods 🔶 Warning 3
Overly long lambda expression 🔶 Warning 3
Magic number 🔶 Warning 2
Overly coupled class 🔶 Warning 1
Unnecessary Javadoc link 🔶 Warning 1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

@EricWittmann EricWittmann requested a review from jsenko February 9, 2024 16:03
@EricWittmann EricWittmann merged commit 64beea2 into main Feb 13, 2024
19 checks passed
@EricWittmann EricWittmann deleted the chore/use-cascade-deletes-in-db branch February 13, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants