Initial upgrade process support #4954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlesarnal
commented
Jul 31, 2024
...provider/src/main/java/io/apicurio/registry/types/provider/AvroArtifactTypeUtilProvider.java
Show resolved
Hide resolved
app/src/main/java/io/apicurio/registry/storage/importing/v2/SqlDataUpgrader.java
Show resolved
Hide resolved
app/src/main/java/io/apicurio/registry/storage/importing/v2/SqlDataUpgrader.java
Outdated
Show resolved
Hide resolved
app/src/main/java/io/apicurio/registry/storage/importing/v2/SqlDataUpgrader.java
Outdated
Show resolved
Hide resolved
app/src/main/java/io/apicurio/registry/storage/importing/v2/SqlDataUpgrader.java
Outdated
Show resolved
Hide resolved
app/src/main/java/io/apicurio/registry/storage/impl/kafkasql/KafkaSqlRegistryStorage.java
Outdated
Show resolved
Hide resolved
app/src/test/java/io/apicurio/registry/DataUpgradeTestProfile.java
Outdated
Show resolved
Hide resolved
app/src/main/java/io/apicurio/registry/upgrade/DataUpgrader.java
Outdated
Show resolved
Hide resolved
app/src/main/java/io/apicurio/registry/upgrade/DataUpgrader.java
Outdated
Show resolved
Hide resolved
| final URL registryV2ExportUrl = regisrtryV2ExportFile.get(); | ||
| try (final InputStream registryV2ExportZip = new BufferedInputStream( | ||
| registryV2ExportUrl.openStream())) { | ||
| log.info("Importing {} on startup.", registryV2ExportUrl); |
There was a problem hiding this comment.
Possible to detect that the ZIP file really is a v2 export? Perhaps by examining the manifest info?
There was a problem hiding this comment.
I can detect it here, but even if I don't it will fail down the path if it's not since all the entities will be parsed to v2 versions, so if it's not a V2 export zip it will fail to import the data. That said, it's probably better to fail fast here.
There was a problem hiding this comment.
Yeah that's what I was thinking: fail fast. Of course that assumes the manifest file is the first entry. Which it is if the ZIP was created by Registry.
EricWittmann
reviewed
Aug 2, 2024
app/src/main/java/io/apicurio/registry/storage/importing/v2/SqlDataUpgrader.java
Outdated
Show resolved
Hide resolved
EricWittmann
reviewed
Aug 2, 2024
app/src/main/java/io/apicurio/registry/storage/importing/v2/SqlDataUpgrader.java
Outdated
Show resolved
Hide resolved
EricWittmann
requested changes
Aug 2, 2024
carlesarnal
force-pushed
the
upgrade-process
branch
from
65c86c7 to
61d3090
Compare
EricWittmann
reviewed
Aug 6, 2024
app/src/main/java/io/apicurio/registry/storage/importing/v2/SqlDataUpgrader.java
Outdated
Show resolved
Hide resolved
carlesarnal
force-pushed
the
upgrade-process
branch
from
ecb93e5 to
7f1d67a
Compare
carlesarnal
force-pushed
the
upgrade-process
branch
2 times, most recently
from
f782dbc to
ce59d31
Compare
carlesarnal
force-pushed
the
upgrade-process
branch
from
ce59d31 to
aae7b85
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces the initial support for migrating from Registry V2 to V3. The current implementation is intended to work as follows:
apicurio.upgrade.file.locationthe user can specify the location of a V2 export file that will be processed and imported into the server.