Moved transaction handling into Handle instead of @Transactional #4966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Qodana Community for JVM38 new problems were found
💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at qodana-support@jetbrains.com
|
jsenko
reviewed
Aug 2, 2024
jsenko
reviewed
Aug 2, 2024
| @@ -687,7 +679,6 @@ private void insertReferences(Handle handle, Long contentId, List<ArtifactRefere | |||
| } | |||
|
|
|||
| @Override | |||
| @Transactional | |||
| public List<String> deleteArtifact(String groupId, String artifactId) | |||
There was a problem hiding this comment.
We should use the GA/GAV value types everywhere to reduce accidental errors, since String is a String is a String. I'd like to add value types for other identifiers in the future, such as hashes and numeric IDs.
There was a problem hiding this comment.
This is out-of-scope for this PR though.
jsenko
reviewed
Aug 2, 2024
app/src/main/java/io/apicurio/registry/storage/impl/sql/SQLServerSqlStatements.java
Outdated
Show resolved
Hide resolved
jsenko
reviewed
Aug 2, 2024
| if (canonical) { | ||
| var artifactMetaData = getArtifactMetaData(groupId, artifactId); | ||
| var artifactMetaData = getArtifactMetaDataRaw(handle, groupId, artifactId); | ||
| Function<List<ArtifactReferenceDto>, Map<String, TypedContent>> referenceResolver = (refs) -> { |
There was a problem hiding this comment.
If you mean because this lamba is the same as another one in this same class, it's because they need to be local in order to pass the local Handle reference.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original work by @jsenko here: