Skip to content

Commit

Permalink
fix: update starknet to 0.7.0 and fix contract error entrypoint not f…
Browse files Browse the repository at this point in the history
…ound (#163)

## Description

Currently, `starknet-rs` is changing some low provider stuff. But also,
it's slow to have PR merged.
For this concern, this PR fixes the contract identification by providing
a separate branch that implement the correct behavior for `starknet-rs`
when a contract
error occurs.

We can now effectively detect `EntrypointNotFound` contract error.

## What type of PR is this? (check all applicable)

- [X] 🐛 Bug Fix (`fix:`)

## Related Tickets & Documents

<!-- 
Please use this format to link related issues: Fixes #<issue_number>
More info:
https://docs.github.com/en/free-pro-team@latest/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword
-->

## Added tests?

- [X] 👍 yes
  • Loading branch information
glihm authored Oct 31, 2023
1 parent a9eaf3e commit babd704
Show file tree
Hide file tree
Showing 5 changed files with 239 additions and 38 deletions.
222 changes: 188 additions & 34 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 1 addition & 2 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,7 @@ ark-metadata = { path = "./crates/ark-metadata" }
pontos = { path = "./crates/pontos" }
diri = { path = "./crates/diri" }
async-trait = "0.1.73"
starknet = "0.6.0"
#starknet = { path = "../../starknet/starknet-rs" }
starknet = { git = "https://github.com/ArkProjectNFTs/starknet-rs", branch = "fix/contract-error" }
anyhow = "1.0"
tokio = { version = "1", features = ["full"] }
log = "0.4.17"
Expand Down
3 changes: 3 additions & 0 deletions crates/ark-starknet/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -14,5 +14,8 @@ num-bigint = "0.4.4"
num-traits = "0.2.17"
thiserror.workspace = true

[dev-dependencies]
tokio = { version = "1", features = ["full"] }

[features]
mock = []
Loading

0 comments on commit babd704

Please sign in to comment.