Skip to content

Commit

Permalink
feat: allow fullscreen without alternative screen
Browse files Browse the repository at this point in the history
  • Loading branch information
rbrugo committed Oct 13, 2023
1 parent d4c9c5e commit bfbb5a0
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion include/ftxui/component/screen_interactive.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ class ScreenInteractive : public Screen {
static ScreenInteractive FixedSize(int dimx, int dimy);
static ScreenInteractive Fullscreen();
static ScreenInteractive FitComponent();
static ScreenInteractive TerminalOutput();
static ScreenInteractive TerminalOutput(bool use_alternative_screen = true);

// Options. Must be called before Loop().
void TrackMouse(bool enable = true);
Expand Down
4 changes: 2 additions & 2 deletions src/ftxui/component/screen_interactive.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -353,12 +353,12 @@ ScreenInteractive ScreenInteractive::FixedSize(int dimx, int dimy) {
}

// static
ScreenInteractive ScreenInteractive::Fullscreen() {
ScreenInteractive ScreenInteractive::Fullscreen(bool use_alternative_screen) {

Check failure on line 356 in src/ftxui/component/screen_interactive.cpp

View workflow job for this annotation

GitHub Actions / Tests (Linux GCC, ubuntu-latest, gcc, gcov)

no declaration matches ‘ftxui::ScreenInteractive ftxui::ScreenInteractive::Fullscreen(bool)’

Check failure on line 356 in src/ftxui/component/screen_interactive.cpp

View workflow job for this annotation

GitHub Actions / Tests (Linux Clang, ubuntu-latest, llvm, llvm-cov gcov)

out-of-line definition of 'Fullscreen' does not match any declaration in 'ftxui::ScreenInteractive'

Check failure on line 356 in src/ftxui/component/screen_interactive.cpp

View workflow job for this annotation

GitHub Actions / Tests (MacOS clang, macos-latest, llvm, llvm-cov gcov)

out-of-line definition of 'Fullscreen' does not match any declaration in 'ftxui::ScreenInteractive'

Check failure on line 356 in src/ftxui/component/screen_interactive.cpp

View workflow job for this annotation

GitHub Actions / Tests (Windows MSVC, windows-latest, cl)

'ftxui::ScreenInteractive ftxui::ScreenInteractive::Fullscreen(bool)': overloaded member function not found in 'ftxui::ScreenInteractive' [D:\a\FTXUI\FTXUI\build\component.vcxproj]
return {
0,
0,
Dimension::Fullscreen,
true,
use_alternative_screen,
};
}

Expand Down

0 comments on commit bfbb5a0

Please sign in to comment.