Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

moved append of header_vals to output dir path to generate_dicom #13

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

tclose
Copy link
Contributor

@tclose tclose commented Sep 30, 2024

so out_dir can be specified directly

@codecov-commenter
Copy link

codecov-commenter commented Sep 30, 2024

Codecov Report

Attention: Patch coverage is 49.01961% with 26 lines in your changes missing coverage. Please review.

Project coverage is 61.22%. Comparing base (0264f09) to head (ee6c3cc).

Files with missing lines Patch % Lines
medimages4tests/dummy/dicom/base.py 33.33% 7 Missing and 1 partial ⚠️
...dummy/dicom/ct/ac/siemens/biograph_vision/vr20b.py 33.33% 1 Missing and 1 partial ⚠️
...icom/ct/wholebody/siemens/biograph_vision/vr20b.py 50.00% 1 Missing and 1 partial ⚠️
...ts/dummy/dicom/mri/dwi/siemens/skyra/syngo_d13c.py 50.00% 1 Missing and 1 partial ⚠️
...om/mri/fmap/ge/discovery_mr888/dv26_0_r05_2008a.py 50.00% 1 Missing and 1 partial ⚠️
...s/dummy/dicom/mri/fmap/siemens/skyra/syngo_d13c.py 50.00% 1 Missing and 1 partial ⚠️
...om/pet/statistics/siemens/biograph_vision/vr20b.py 50.00% 1 Missing and 1 partial ⚠️
...icom/pet/topogram/siemens/biograph_vision/vr20b.py 50.00% 1 Missing and 1 partial ⚠️
...m/pet/uncorrected/siemens/biograph_vision/vr20b.py 50.00% 1 Missing and 1 partial ⚠️
...com/pet/wholebody/siemens/biograph_vision/vr20b.py 50.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #13      +/-   ##
==========================================
- Coverage   64.54%   61.22%   -3.33%     
==========================================
  Files          31       31              
  Lines         440      459      +19     
  Branches       61       71      +10     
==========================================
- Hits          284      281       -3     
- Misses        135      148      +13     
- Partials       21       30       +9     
Flag Coverage Δ
61.00% <49.01%> (-3.32%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tclose tclose merged commit d90cdd0 into main Sep 30, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants