Skip to content

Conversation

itspvty
Copy link
Contributor

@itspvty itspvty commented Aug 18, 2025

Task

AARD-1896

The goal was to create a functional UI for the Match Results screen after a game that was played in Match Mode had concluded. It's styled to resemble the official FIRST FRC Game Conclusion screen used during broadcasts.

Symptom

The old Match Results screen wasn't very visually appealing and didn't contain data in a way that was easy to read.

Solution

The screen was modified to be more user friendly (by piggybacking on the style choices of FIRST), and contain more data

Verification

Verify that data (aside from placeholder data) updates correctly and that all UI elements are visually correct on multiple device resolutions.


Before merging, ensure the following criteria are met:

  • All acceptance criteria outlined in the ticket are met.
  • Necessary test cases have been added and updated.
  • A feature toggle or safe disable path has been added (if applicable).
  • User-facing polish:
    • Ask: "Is this ready-looking?"
  • Cross-linking between Jira and GitHub:
    • PR links to the relevant Jira issue.
    • Jira ticket has a comment referencing this PR.

@rutmanz
Copy link
Member

rutmanz commented Aug 18, 2025

image

Copy link
Member

@ryanzhangofficial ryanzhangofficial left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥🔥🔥

Copy link
Contributor

@azaleacolburn azaleacolburn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't actually collect information about the score breakdown at the moment, so I don't think we should display placeholder values breaking down the score in this way. Instead we should either:

  • Remove that section for the time being (or put "Coming Soon" or smth similar) or
  • Break down scoring by scoring zone, rather than general scoring method.

@AlexD717 AlexD717 added the ui/ux Relating to user interface, or in general, user experience label Aug 19, 2025
@itspvty itspvty requested a review from azaleacolburn August 20, 2025 22:14
Copy link
Member

@AlexD717 AlexD717 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@PepperLola PepperLola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@PepperLola PepperLola force-pushed the aries/1896/scoreboard-ui branch from e8fc89e to cf2312e Compare August 22, 2025 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-merge ui/ux Relating to user interface, or in general, user experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants