-
Notifications
You must be signed in to change notification settings - Fork 61
Match Results Screen Overhaul [AARD-1896]
#1283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥🔥🔥
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't actually collect information about the score breakdown at the moment, so I don't think we should display placeholder values breaking down the score in this way. Instead we should either:
- Remove that section for the time being (or put "Coming Soon" or smth similar) or
- Break down scoring by scoring zone, rather than general scoring method.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice
e8fc89e
to
cf2312e
Compare
Task
AARD-1896
The goal was to create a functional UI for the Match Results screen after a game that was played in Match Mode had concluded. It's styled to resemble the official FIRST FRC Game Conclusion screen used during broadcasts.
Symptom
The old Match Results screen wasn't very visually appealing and didn't contain data in a way that was easy to read.
Solution
The screen was modified to be more user friendly (by piggybacking on the style choices of FIRST), and contain more data
Verification
Verify that data (aside from placeholder data) updates correctly and that all UI elements are visually correct on multiple device resolutions.
Before merging, ensure the following criteria are met: