-
Notifications
You must be signed in to change notification settings - Fork 806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the launch bar from the frontend of unpublished atomic sites #41113
base: trunk
Are you sure you want to change the base?
Conversation
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Follow this PR Review Process:
Still unsure? Reach out in #jetpack-developers for guidance! Wpcomsh plugin:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
The launch bar is now removed from simple site |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works well on the tests I did 👍
Related to Automattic/wp-calypso#96199
Equivalent to 169353-ghe-Automattic/wpcom but for atomic
This PR removes the launch bar entirely from atomic sites (like requested in the related issue).
It also makes a small change to wpcom-mu-plugin, it removes a reference to the DOM element of the bar even though that code was dead code anyway. (the global styles upsell not rendering in atomic at all)
Testing instructions:
Does this pull request change what data or activity we track or use?
No