Merge pull request #7732 from Automattic/update/replace-unlink-with-w…

…p_delete_file Replace `unlink` with `wp_delete_file`
Automattic · Jan 14, 2025 · cd4e022 · cd4e022
2 parents 1984ab6 + d57cfa0
commit cd4e022
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 4 deletions.
diff --git a/changelog/update-replace-unlink-with-wp_delete_file b/changelog/update-replace-unlink-with-wp_delete_file
@@ -0,0 +1,4 @@
+Significance: patch
+Type: changed
+
+Replace `unlink` with `wp_delete_file`
diff --git a/includes/data-port/class-sensei-data-port-job.php b/includes/data-port/class-sensei-data-port-job.php
@@ -212,7 +212,7 @@ public function get_results() {
 	public function get_logs() {
 		usort(
 			$this->logs,
-			function( $first_log, $second_log ) {
+			function ( $first_log, $second_log ) {
 
 				// Get the type ordering and compare the two logs based on that.
 				$log_order                = $this->get_log_type_order();
@@ -514,7 +514,7 @@ public function save_file( $file_key, $tmp_file, $file_name ) {
 		$move_new_file = @copy( $tmp_file, $file_save_path );
 
 		if ( 0 === strpos( $tmp_file, sys_get_temp_dir() ) ) {
-			unlink( $tmp_file );
+			wp_delete_file( $tmp_file );
 		}
 
 		if ( ! $move_new_file || ! file_exists( $file_save_path ) ) {

diff --git a/includes/data-port/export-tasks/class-sensei-export-task.php b/includes/data-port/export-tasks/class-sensei-export-task.php
@@ -258,10 +258,11 @@ public function add_file_to_job( $tmp_file ) {
 		$type     = $this->get_content_type();
 		$date     = gmdate( 'Y-m-d' );
 		$filename = sanitize_file_name( get_bloginfo( 'name' ) . '-' . ucwords( $type ) . 's-' . $date . '.csv' );
+
 		$this->get_job()->save_file( $type, $tmp_file, $filename );
+
 		if ( file_exists( $tmp_file ) ) {
-			unlink( $tmp_file );
+			wp_delete_file( $tmp_file );
 		}
 	}
-
 }