feat: introduce php-helpers image
#1105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjinks
commented
Mar 4, 2025
php-helpers/Dockerfile
Outdated
Comment on lines
40
to
45
| echo 'DPkg::Pre-Invoke { "rm -f /var/lib/dpkg/info/*.postinst || true"; };' > /etc/apt/apt.conf.d/99local && \ | ||
| xx-apt-get install --no-install-recommends -y -oDPkg::ConfigurePending=0 libglib2.0-dev || true && \ | ||
| xx-apt-get install --no-install-recommends -y -oDPkg::ConfigurePending=0 libglib2.0-dev || true && \ | ||
| xx-apt-get install --no-install-recommends -y -oDPkg::ConfigurePending=0 libglib2.0-dev && \ | ||
| xx-apt-get install --no-install-recommends -y -oDPkg::ConfigurePending=0 \ | ||
| zlib1g-dev libpcre3-dev libssl-dev libzstd-dev libmysqlclient-dev |
There was a problem hiding this comment.
This was a nightmare.
libglib2.0-dev wants python, python wants to run a bunch of CPU-heavy scripts, which cannot run on a foreign architecture.
The solution was to ignore errors, remove all installed postinst scripts, and try until we succeed.
There was a problem hiding this comment.
Maybe try this: https://gist.github.com/kwilczynski/6e4f6f877b5887b9a152225ea5caee28 someday.
sjinks
commented
Mar 4, 2025
php-helpers/Dockerfile
Outdated
Comment on lines
30
to
32
| xx-apt-get update && \ | ||
| apt-get install -y shtool php-pear && \ | ||
| sed -i '/^Package: shtool$/a Multi-Arch: foreign' /var/lib/dpkg/status && \ |
There was a problem hiding this comment.
sjinks
commented
Mar 4, 2025
| xx-apt-get update && \ | ||
| apt-get install -y shtool php-pear && \ | ||
| sed -i '/^Package: shtool$/a Multi-Arch: foreign' /var/lib/dpkg/status && \ | ||
| pecl bundle timezonedb |
There was a problem hiding this comment.
We must download and unpack everything we need from PECL because xx-apt-get install phpXX-dev might overwrite pecl with the binary with a foreign architecture, which we cannot run.
That is why we run pecl here and then forget it existed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
ghcr.io/automattic/vip-container-images/php-helpersimage to reduce the build time for PHP images.When building a PHP image, we spend a lot of time building mydumper and PHP extensions (and installing build dependencies). This is especially slow for the
linux/arm64variant because it runs under QEMU.To the contrary, the
php-helpersimage employs cross-compilation instead of emulation. As a result, it takes less than three minutes to build all artifacts for both architectures.To test:
cd php-helpers docker buildx bake ls -1R IMAGEThe expected output is