Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I'm fixing the Terraform deployment and upgrade it to the latest version of the AzureRM Provider (v4.24.0) #207

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

abossard
Copy link

@abossard abossard commented Mar 24, 2025

Purpose

This pull request includes various updates to the Terraform configuration files, focusing on upgrading provider versions, enhancing Kubernetes cluster settings, and modifying cognitive deployment resources.

Provider and Version Updates:

  • Updated azurerm provider version from 3.113.0 to 4.24.0 in infra/terraform/main.tf.
  • Removed infra/terraform/.terraform.lock.hcl and added it to the gitignore.

Kubernetes Cluster Enhancements:

  • Enabled local_account_disabled, role_based_access_control_enabled, and azure_policy_enabled in azurerm_kubernetes_cluster resource in infra/terraform/kubernetes.tf.
  • Changed node_os_channel_upgrade to automatic_upgrade_channel in azurerm_kubernetes_cluster resource in infra/terraform/kubernetes.tf.

Cognitive Deployment Modifications:

  • Added dynamic_throttling_enabled and replaced scale with sku in azurerm_cognitive_deployment resources in infra/terraform/openai.tf [1] [2].

Miscellaneous Changes:

  • Added request_headers to data "http" "ifconfig" in infra/terraform/main.tf.
  • Updated default values for openai_model_name and openai_model_version in infra/terraform/variables.tf.

Does this introduce a breaking change?

[x] Yes, or at least I would assume it'll recreate some Azure resources
[ ] No

Pull Request Type

What kind of change does this Pull Request introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

  • Get the code
azd up
  • Test the code

What to Check

Verify that the following are valid

  • ...

Other Information

Andre Bossard added 3 commits March 24, 2025 09:00
- Set local_account_disabled to false in kubernetes.tf
- Comment out Azure Active Directory RBAC configuration
- Comment out API server access profile configuration
- Add new health diagram in SVG format
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant