Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update productionizing.md #1677

Merged
merged 2 commits into from
Jun 3, 2024
Merged

Conversation

simonkurtz-MSFT
Copy link
Contributor

Purpose

Add link to PR for openai-priority-loadbalancer to offer a native Python approach via an injected httpx transport.

Does this introduce a breaking change?

When developers merge from main and run the server, azd up, or azd deploy, will this produce an error?
If you're not sure, try it out on an old environment.

[ ] Yes
[x] No

Does this require changes to learn.microsoft.com docs?

This repository is referenced by this tutorial
which includes deployment, settings and usage instructions. If text or screenshot need to change in the tutorial,
check the box below and notify the tutorial author. A Microsoft employee can do this for you if you're an external contributor.

[ ] Yes
[x] No

Type of change

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[x] Documentation content changes
[ ] Other... Please describe:

Code quality checklist

See CONTRIBUTING.md for more details.

  • The current tests all pass (python -m pytest).
  • I added tests that prove my fix is effective or that my feature works
  • I ran python -m pytest --cov to verify 100% coverage of added lines
  • I ran python -m mypy to check for type errors
  • I either used the pre-commit hooks or ran ruff and black manually on my code.

Add link to PR for openai-priority-loadbalancer
@simonkurtz-MSFT
Copy link
Contributor Author

Hi @pamelafox, here's the requested PR.

docs/productionizing.md Outdated Show resolved Hide resolved
docs/productionizing.md Outdated Show resolved Hide resolved
@simonkurtz-MSFT
Copy link
Contributor Author

#sign-off

@pamelafox
Copy link
Collaborator

Ah our repo doesn't have the azure-docs-pr label magic. I'll merge! :)

@pamelafox pamelafox merged commit 938c674 into Azure-Samples:main Jun 3, 2024
4 checks passed
@simonkurtz-MSFT
Copy link
Contributor Author

@pamelafox, thank you! I also just updated the PR overview on #1626 to give more context to the PR.

@simonkurtz-MSFT simonkurtz-MSFT deleted the patch-1 branch June 3, 2024 18:42
@simonkurtz-MSFT
Copy link
Contributor Author

Ah our repo doesn't have the azure-docs-pr label magic. I'll merge! :)

Ah our repo doesn't have the azure-docs-pr label magic. I'll merge! :)

Ha, you can tell what I was thinking with that then. =P

@pamelafox
Copy link
Collaborator

Oh great, thanks for updating the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants