Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

πŸ› Fix invalid YAML #10130

Closed
wants to merge 3 commits into from
Closed

Conversation

pemontto
Copy link
Contributor

Required items, please complete

Change(s):

  • Remove trailing tabs \t

Reason for Change(s):

  • Fix analytics with invalid YAML that cause parsers to barf

Version Updated: βœ…

Testing Completed: βœ…

@pemontto pemontto requested review from a team as code owners March 12, 2024 22:11
@v-atulyadav v-atulyadav self-assigned this Mar 13, 2024
@v-atulyadav v-atulyadav added Solution Solution specialty review needed Analytic Rules labels Mar 13, 2024
@v-atulyadav
Copy link
Contributor

Hi @pemontto,
Could you please repackage these solutions. You can check below link for your reference. Thanks
https://github.com/Azure/Azure-Sentinel/blob/master/Tools/Create-Azure-Sentinel-Solution/V3/README.md

@pemontto
Copy link
Contributor Author

@v-atulyadav repackaged based on docs provided πŸ‘

@v-atulyadav
Copy link
Contributor

Hi @pemontto,
Veritas is a partner solution, and in this solution metadata file, it shows Microsoft support, so we need to modify this file accordingly. Thanks

@v-atulyadav
Copy link
Contributor

Hi @pemontto,
Moving this into draft until further update. Thanks

@v-atulyadav v-atulyadav marked this pull request as draft April 5, 2024 05:01
@pemontto
Copy link
Contributor Author

pemontto commented Apr 8, 2024

@v-atulyadav, this is the same metadata file from 6 months ago. What should it be changed to? I don't work for Veritas, but these rules are breaking CI/CD pipelines.

Solutions/Veritas NetBackup/Data/Solution_NetBackup.json

{
	"Name": "Veritas NetBackup",
	"Author": "Microsoft - support@microsoft.com",
	"Logo": "<img src=\"https://raw.githubusercontent.com/Azure/Azure-Sentinel/master/Logos/Azure_Sentinel.svg\" width=\"75px\" height=\"75px\">",
	"Description": "The [Veritas](https://www.veritas.com/) solution for Microsoft Sentinel allows you to analyze NetBackup audit events. The solution uses analytics rules to automatically generate incidents when an abnormal user activity is detected in NetBackup.",
	"Analytic Rules": [
		"Analytic Rules/NetBackup_many_Anomalies.yaml",
		"Analytic Rules/NetBackup_many_login_fail.yaml"
		],
	"Metadata": "SolutionMetadata.json",
	"BasePath": "C:\\GitHub\\Azure-Sentinel\\Solutions\\Veritas NetBackup",
	"Version": "3.0.0",
	"TemplateSpec": true,
	"Is1PConnector": false
}

@v-atulyadav
Copy link
Contributor

Hi @pemontto,
We have asked the original author to change these values; once he updates these values, we will proceed with this change. Thanks

@v-atulyadav
Copy link
Contributor

Hi @pemontto,
The original author has raised a PR for changes, and we will incorporate your changes into that PR. Thanks

@v-atulyadav
Copy link
Contributor

Hi @pemontto,
We have raised a new PR #10837 for Spycloud solution changes mentioned in this PR, requesting you to uncommit these changes from this PR. Thanks

@v-atulyadav
Copy link
Contributor

Hi @pemontto,
We have raised a new PR #10852 for Veritas solution changes mentioned in this PR.
This request is being closed because your two solutions changes have been implemented. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Analytic Rules Solution Solution specialty review needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants