Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding entity mapping to the URLEntity_CloudAppEvents.yaml #11119

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

aprakash13
Copy link
Contributor

  1. Adding entity mapping to the URLEntity_CloudAppEvents.yaml

  2. Also it seemed that the URL field wasn't being parsed correctly. The extract function seemed to have a semicolon at the end, which suggested that URLs were expected to end with a semicolon—it seems this isn't always the case.
    Removing the semicolons from three yaml files.

    Required items, please complete

    Change(s):

    • See guidance below

    Reason for Change(s):

    • See guidance below

    Version Updated:

    • Required only for Detections/Analytic Rule templates
    • See guidance below

    Testing Completed:

    • See guidance below

    Checked that the validations are passing and have addressed any issues that are present:

    • See guidance below

Guidance <- remove section before submitting


Before submitting this PR please ensure that you have read the following sections and filled out the changes, reason for change and testing complete sections:

Thank you for your contribution to the Microsoft Sentinel Github repo.

Details of the code changes in your submitted PR. Providing descriptions for pull requests ensures there is context to changes being made and greatly enhances the code review process. Providing associated Issues that this resolves also easily connects the reason.

Change(s):

  • Updated syntax for XYZ.yaml

Reason for Change(s):

Version updated:

  • Yes
  • Detections/Analytic Rule templates are required to have the version updated

The code should have been tested in a Microsoft Sentinel environment that does not have any custom parsers, functions or tables, so that you validate no incorrect syntax and execution functions properly. If your submission requires a custom parser or function, it must be submitted with the PR.

Testing Completed:

  • Yes/No/Need Help

Note: If updating a detection, you must update the version field.

Before the submission has been made, please look at running the KQL and Yaml Validation Checks locally.
https://github.com/Azure/Azure-Sentinel#run-kql-validation-locally

Checked that the validations are passing and have addressed any issues that are present:

  • Yes/No/Need Help

Note: Let us know if you have tried fixing the validation error and need help.

References:


Also it seemd that the URL field wasn't being parsed correctly. The extract function seemed to have a semicolon at the end, which suggested that URLs were expected to end with a semicolon—it seems this isn't always the case.
Removing the semicolons in three yaml files.
@aprakash13 aprakash13 requested review from a team as code owners September 12, 2024 00:11
Copy link

Hello how are you I am GitHub bot
😀😀
I see that you changed templates under the detections/analytic rules folder. Did you remember to update the version of the templates you changed?
If not, and if you want customers to be aware that a new version of this template is available, please update the version property of the template you changed.

@aprakash13 aprakash13 merged commit c45dd79 into master Sep 12, 2024
35 checks passed
@v-atulyadav v-atulyadav self-assigned this Sep 12, 2024
@v-atulyadav v-atulyadav added Analytic Rules Solution Solution specialty review needed labels Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Analytic Rules Solution Solution specialty review needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants