Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Idoscapa/mdiot analyticrules entities #11645

Merged
merged 2 commits into from
Jan 9, 2025
Merged

Idoscapa/mdiot analyticrules entities #11645

merged 2 commits into from
Jan 9, 2025

Conversation

idoscapa
Copy link
Collaborator

@idoscapa idoscapa commented Jan 9, 2025

Required items, please complete

Change(s):

  • Updated MDIoT analytic rules entities mapping

Reason for Change(s):

  • Issue of mapping only IPs entities instead of all Sentinel Entities

Version Updated:

  • Yes

Testing Completed:

  • Need help

Checked that the validations are passing and have addressed any issues that are present:

  • Need help

@idoscapa idoscapa requested review from a team as code owners January 9, 2025 10:24
rahul0216
rahul0216 approved these changes Jan 9, 2025
View reviewed changes
Copy link
Contributor

@rahul0216 rahul0216 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good.

@rahul0216 rahul0216 self-assigned this Jan 9, 2025
@v-atulyadav v-atulyadav added Solution Solution specialty review needed Analytic Rules labels Jan 9, 2025
@v-prasadboke v-prasadboke merged commit cb54692 into Azure:master Jan 9, 2025
49 checks passed
@rahul0216 rahul0216 added the P0 label Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@v-prasadboke v-prasadboke v-prasadboke approved these changes

@rahul0216 rahul0216 rahul0216 approved these changes

Assignees

@rahul0216 rahul0216

@v-prasadboke v-prasadboke

Labels
Analytic Rules P0 Solution Solution specialty review needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@idoscapa @rahul0216 @v-prasadboke @v-atulyadav