Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Cross-Cloud GCP Detection #9153

Merged
merged 24 commits into from
Oct 31, 2023
Merged

Conversation

4R9UN
Copy link
Contributor

@4R9UN 4R9UN commented Oct 4, 2023

Required items, please complete

Change(s):

  • New Detection Created

Reason for Change(s):

  • See guidance below

Version Updated:

  • Required only for Detections/Analytic Rule templates
  • See guidance below

Testing Completed:

  • See guidance below

Checked that the validations are passing and have addressed any issues that are present:

  • See guidance below

Guidance <- remove section before submitting


Before submitting this PR please ensure that you have read the following sections and filled out the changes, reason for change and testing complete sections:

Thank you for your contribution to the Microsoft Sentinel Github repo.

Details of the code changes in your submitted PR. Providing descriptions for pull requests ensures there is context to changes being made and greatly enhances the code review process. Providing associated Issues that this resolves also easily connects the reason.

Change(s):

  • Updated syntax for XYZ.yaml

Reason for Change(s):

Version updated:

  • Yes
  • Detections/Analytic Rule templates are required to have the version updated

The code should have been tested in a Microsoft Sentinel environment that does not have any custom parsers, functions or tables, so that you validate no incorrect syntax and execution functions properly. If your submission requires a custom parser or function, it must be submitted with the PR.

Testing Completed:

  • Yes/No/Need Help

Note: If updating a detection, you must update the version field.

Before the submission has been made, please look at running the KQL and Yaml Validation Checks locally.
https://github.com/Azure/Azure-Sentinel#run-kql-validation-locally

Checked that the validations are passing and have addressed any issues that are present:

  • Yes/No/Need Help

Note: Let us know if you have tried fixing the validation error and need help.

References:


@4R9UN 4R9UN requested review from a team as code owners October 4, 2023 15:14
@4R9UN 4R9UN added the Detection Detection specialty review needed label Oct 4, 2023
@Azure Azure deleted a comment from github-actions bot Oct 4, 2023
Copy link
Contributor Author

@4R9UN 4R9UN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update the GUID

@v-atulyadav v-atulyadav self-assigned this Oct 5, 2023
Copy link
Contributor Author

@4R9UN 4R9UN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated Description under 255 char

Copy link
Contributor Author

@4R9UN 4R9UN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixing the Severity error

@Azure Azure deleted a comment from github-actions bot Oct 5, 2023
@Azure Azure deleted a comment from github-actions bot Oct 5, 2023
@Azure Azure deleted a comment from github-actions bot Oct 5, 2023
@Azure Azure deleted a comment from github-actions bot Oct 5, 2023
@Azure Azure deleted a comment from github-actions bot Oct 5, 2023
Copy link
Contributor Author

@4R9UN 4R9UN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix description error

Copy link
Contributor Author

@4R9UN 4R9UN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixing syntax error

Copy link
Contributor Author

@4R9UN 4R9UN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the Tactics

@Azure Azure deleted a comment from github-actions bot Oct 5, 2023
@Azure Azure deleted a comment from github-actions bot Oct 6, 2023
Copy link
Contributor Author

@4R9UN 4R9UN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixing error

Copy link
Contributor Author

@4R9UN 4R9UN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix error

Copy link
Contributor Author

@4R9UN 4R9UN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Slight Change in description

@4R9UN 4R9UN requested a review from petebryan October 6, 2023 13:17
@Azure Azure deleted a comment from github-actions bot Oct 6, 2023
@Azure Azure deleted a comment from github-actions bot Oct 6, 2023
@Azure Azure deleted a comment from github-actions bot Oct 6, 2023
@Azure Azure deleted a comment from github-actions bot Oct 6, 2023
@Azure Azure deleted a comment from github-actions bot Oct 6, 2023
@Azure Azure deleted a comment from github-actions bot Oct 6, 2023
@v-atulyadav v-atulyadav self-assigned this Oct 9, 2023
@github-actions
Copy link
Contributor

Hello how are you I am GitHub bot
😀😀
I see that you changed templates under the detections/analytic rules folder. Did you remember to update the version of the templates you changed?
If not, and if you want customers to be aware that a new version of this template is available, please update the version property of the template you changed.

alertDisplayNameFormat: "IP address {{GCPUserIp}} Assocated with {{AlertName}} found in GCP VM creation event by {{GCPUserUPN}}"
alertDescriptionFormat: "This detection correlates '{{ProductName}}' Alert IP addresse Entity found in VM instance creation in GCP {{ProjectId}}. It identifies successful compute instance creation, from suspicious IP addresse. By joining these datasets on network entities and IP addresses, it detects unauthorized Initial access attempts across GCP environments."
alertSeverityColumnName: AlertSeverity
alertDynamicProperties:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about setting the alert severity based on the original Microsoft alert severity?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, That Could be varies based on Microsoft Alerts

- alertProperty: ProviderName
value: "Microsoft Security"
- alertProperty: ProductName
value: "Defeder"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this meant to be "Defender"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

- alertProperty: ProductName
value: "Defeder"
- alertProperty: ProductComponentName
value: "Defeder"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this meant to be "Defender"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@github-actions
Copy link
Contributor

Hello how are you I am GitHub bot
😀😀
I see that you changed templates under the detections/analytic rules folder. Did you remember to update the version of the templates you changed?
If not, and if you want customers to be aware that a new version of this template is available, please update the version property of the template you changed.

Copy link
Contributor Author

@4R9UN 4R9UN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Address Comments

@v-atulyadav v-atulyadav merged commit a42b6f2 into master Oct 31, 2023
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Detection Detection specialty review needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants