Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Required dataconnector for PrivilegedAccountPermissionsChanged.yaml #9311

Merged
merged 6 commits into from
Nov 3, 2023

Conversation

v-sabiraj
Copy link
Contributor

@v-sabiraj v-sabiraj commented Oct 31, 2023

Required items, please complete

Change(s):

  • Updated hunting query description, updated data type for Analytic rules

Reason for Change(s):

  • The description of hunting query was exceeding 255 characters, and the datatypes were not updated.

Version Updated:
yes

Testing Completed:

  • yes

Checked that the validations are passing and have addressed any issues that are present:

  • See guidance below

Guidance <- remove section before submitting


Before submitting this PR please ensure that you have read the following sections and filled out the changes, reason for change and testing complete sections:

Thank you for your contribution to the Microsoft Sentinel Github repo.

Details of the code changes in your submitted PR. Providing descriptions for pull requests ensures there is context to changes being made and greatly enhances the code review process. Providing associated Issues that this resolves also easily connects the reason.

Change(s):

  • Updated syntax for XYZ.yaml

Reason for Change(s):

Version updated:

  • Yes
  • Detections/Analytic Rule templates are required to have the version updated

The code should have been tested in a Microsoft Sentinel environment that does not have any custom parsers, functions or tables, so that you validate no incorrect syntax and execution functions properly. If your submission requires a custom parser or function, it must be submitted with the PR.

Testing Completed:

  • Yes/No/Need Help

Note: If updating a detection, you must update the version field.

Before the submission has been made, please look at running the KQL and Yaml Validation Checks locally.
https://github.com/Azure/Azure-Sentinel#run-kql-validation-locally

Checked that the validations are passing and have addressed any issues that are present:

  • Yes/No/Need Help

Note: Let us know if you have tried fixing the validation error and need help.

References:


@v-sabiraj v-sabiraj requested review from a team as code owners October 31, 2023 18:55
Copy link
Contributor

Hello how are you I am GitHub bot
😀😀
I see that you changed templates under the detections/analytic rules folder. Did you remember to update the version of the templates you changed?
If not, and if you want customers to be aware that a new version of this template is available, please update the version property of the template you changed.

@v-sabiraj
Copy link
Contributor Author

/package

@v-atulyadav v-atulyadav added the Solution Solution specialty review needed label Nov 1, 2023
@v-dvedak
Copy link
Contributor

v-dvedak commented Nov 1, 2023

Hi @v-sabiraj, please check on the validations that are failing.

@v-dvedak
Copy link
Contributor

v-dvedak commented Nov 1, 2023

Hi @v-sabiraj, for the HQ (PrivilegedAccountPermissionsChanged.yaml) which is updated in this PR, the description is > 255 characters.

Copy link
Contributor

github-actions bot commented Nov 2, 2023

Hello how are you I am GitHub bot
😀😀
I see that you changed templates under the detections/analytic rules folder. Did you remember to update the version of the templates you changed?
If not, and if you want customers to be aware that a new version of this template is available, please update the version property of the template you changed.

Copy link
Contributor

github-actions bot commented Nov 2, 2023

Hello how are you I am GitHub bot
😀😀
I see that you changed templates under the detections/analytic rules folder. Did you remember to update the version of the templates you changed?
If not, and if you want customers to be aware that a new version of this template is available, please update the version property of the template you changed.

Copy link
Contributor

github-actions bot commented Nov 3, 2023

Hello how are you I am GitHub bot
😀😀
I see that you changed templates under the detections/analytic rules folder. Did you remember to update the version of the templates you changed?
If not, and if you want customers to be aware that a new version of this template is available, please update the version property of the template you changed.

@v-sabiraj
Copy link
Contributor Author

image
Updated description

Copy link
Contributor

github-actions bot commented Nov 3, 2023

Hello how are you I am GitHub bot
😀😀
I see that you changed templates under the detections/analytic rules folder. Did you remember to update the version of the templates you changed?
If not, and if you want customers to be aware that a new version of this template is available, please update the version property of the template you changed.

Copy link
Contributor

@rahul0216 rahul0216 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good.

@v-dvedak v-dvedak merged commit e3015ac into master Nov 3, 2023
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-package Content-Package Solution Solution specialty review needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants