[Feature] Add AAD Custom Auth Support & Setup Custom Auth Framework #878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Timothyw0
requested review from
andimarc and
adrianhall
and removed request for
cjk7989
github-actions
bot
added
scope: core
Timothyw0
changed the title
adrianhall
reviewed
Aug 7, 2024
…tching to use supported auth constant list.
mkarmark
approved these changes
Aug 13, 2024
Timothyw0
pushed a commit
to Timothyw0/static-web-apps-cli
that referenced
this pull request
Dec 15, 2024
Timothyw0
pushed a commit
to Timothyw0/static-web-apps-cli
that referenced
this pull request
Dec 27, 2024
This reverts commit 83d3ca4.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New feature: Adding AAD custom auth support using the previously created code for Google and GitHub. The previous code has been refactored and generalized for future auth providers to be added as well. Google and Github auth has also been regression tested successfully.
Tested in private environment with custom AAD application using the following staticwebapp.config.json:
Successful /.auth/me call with AAD credentials:
Successful /.auth/me call with Github credentials:
Successful /.auth/me call with Google credentials:
