[draft] mTLS POP using Pop Authentication Operation #5463
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trwalke
reviewed
Sep 8, 2025
| @@ -127,6 +127,15 @@ public string Claims | |||
| } | |||
| } | |||
|
|
|||
| internal void OverrideAuthenticationScheme(IAuthenticationOperation authenticationOperation) | |||
| { | |||
| if (IsMtlsPopRequested) | |||
There was a problem hiding this comment.
Discussed offline with Gladwin. this check will be moved to the MSI request
There was a problem hiding this comment.
thanks for the feedback, Travis
gladjohn
commented
Sep 8, 2025
| namespace Microsoft.Identity.Client.AuthScheme.PoP | ||
| { | ||
| /// <summary> | ||
| /// This is just a demo class. Real implementation of MTLS PoP should use <see cref="MtlsPopAuthenticationOperation"/>. |
There was a problem hiding this comment.
This is just a demo class. Real implementation of MTLS PoP should use MtlsPopAuthenticationOperation
gladjohn
commented
Sep 8, 2025
| { | ||
| return new Dictionary<string, string> | ||
| { | ||
| { OAuth2Parameter.TokenType, Constants.BearerTokenType } |
There was a problem hiding this comment.
Managed identity only returns a Bearer Token now, hence using BearerTokenType. Final implementation needs to use MtlsPopAuthenticationOperation
There was a problem hiding this comment.
What token_type gets put on the wire?
There was a problem hiding this comment.
mtls_pop when the new .WithMtlsPop API is used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[draft] mTLS POP using Pop Authentication Operation
DO NOT MERGE THIS