-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Workaround to fix VS build hang in certain scenarios #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philnach
commented
Feb 14, 2025
philnach
commented
Feb 14, 2025
...ons/Parquet/Cosmos.DataTransfer.ParquetExtension/Cosmos.DataTransfer.ParquetExtension.csproj
Show resolved
Hide resolved
philnach
commented
Feb 14, 2025
...os.DataTransfer.CognitiveSearchExtension/Cosmos.DataTransfer.CognitiveSearchExtension.csproj
Show resolved
Hide resolved
philnach
commented
Feb 14, 2025
...ons/Parquet/Cosmos.DataTransfer.ParquetExtension/Cosmos.DataTransfer.ParquetExtension.csproj
Show resolved
Hide resolved
philnach
commented
Feb 14, 2025
...lServer/Cosmos.DataTransfer.SqlServerExtension/Cosmos.DataTransfer.SqlServerExtension.csproj
Outdated
Show resolved
Hide resolved
@philnach and @bowencode is this good to go? |
bowencode
approved these changes
Feb 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change Fixes #163 by switching from exec dotnet to using msbuild.
Root cause:
The custom target in the projects: dotnet publish --configuration $(Configuration) --no-build -p:PublishProfile=FolderProfile"
WaitForExit on MSBuild side is waiting for this pipe to close and app hangs
A better analysis is provided here and why it is problematic:
Process.WaitForExit() hangs forever even though the process has exited in some cases · Issue #29232 · dotnet/runtime
Fix:
Switch to using msbuild vs. exec dotnet
How validated: