-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for SqlServer JSON Fields #166
Support for SqlServer JSON Fields #166
Conversation
Added support for processing JSON data from SQL Query Updated the Readme.md
@quisitive-crogers , can you take a look at the merge conflicts and then we can review your change? |
Done! |
Thanks, I'll re-take a look at the PR later today. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fast turnaround and fixing the formatting.
@quisitive-crogers, looks like tests are failing with your change. Can you take a look? You should be able to reproduce the failure by running: Here's the failure:
|
Fixed. Not sure those are really appropriate as unit tests, but for the time being, I just got them working again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, took me a bit to understand myself why it was failing. I see the break was because we are now validating the SqlServerExtensions settings. Good addition!
Added a common string -> IDataItem method
Added support for processing JSON data from SQL Query
Updated the Readme.md