Fix/sound api and recorder #384
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-Create a new *Directory* named "roms" and load all .gb's into it -run game_launcher.py
Create game_launcher.py
…ch frame- issue 217
…ding, Rom directory, screen recording, adjusting volume.
…rder with Sound - Implemented sound extraction API and screen recorder with synchronized audio. Added documentation and test files. Pair programmed by Jordan and Bella Russell
|
the 2 issues |
|
Hi, thank you for your PR. You'll need to clean it up a bit. You've commited your virtual env etc. Also please go through each file and remove the things that are not explicitly needed -- like pinning the requirements and adding a comment about AI to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.