Refactoring: enable c++20 support #1968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Tatsujin1978
commented
May 5, 2024
Tatsujin1978
commented
- enable c++20 support
- in order to be compiled and linked it needs >= boost 1.77 (1.75 raises linking error with known bug in 1.75)
- fixed atomic swap tests (exception)
- minor refactoring
- changed LOG_* macros names to their corresponding BEAM_LOG_* names (preparation for libbitcoin update)
BEAM_LOG_UNHANDLED_EXCEPTION BEAM_LOG_CRITICAL BEAM_LOG_ERROR BEAM_LOG_INFO BEAM_LOG_MESSAGE
fixed atomic_swap.cpp
anatolse
previously approved these changes
May 6, 2024
|
@Tatsujin1978 could you please resolve this? |
sure |
Committed changes, should be fine |
anatolse
previously approved these changes
May 10, 2024
anatolse
approved these changes
May 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.