Fixed aggressive trimming, causing JSON file to not load when adding …

…a SoundFont to the list
BlackMIDIDevs · Feb 28, 2025 · 0b33c0b · 0b33c0b
1 parent 05edcf5
commit 0b33c0b
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 5 deletions.
diff --git a/OmniConverter/Extensions/SoundFonts.cs b/OmniConverter/Extensions/SoundFonts.cs
@@ -47,6 +47,7 @@ public class SoundFont : INotifyPropertyChanged
         [JsonProperty]
         public bool NoRampIn { get; private set; }
 
+        [JsonIgnore]
         public string SoundFontDisplayName => $"{(Enabled ? "" : "[OFF] ")}{SoundFontPath}";
 
         public SoundFont()

diff --git a/OmniConverter/OmniConverter.csproj b/OmniConverter/OmniConverter.csproj
@@ -2,7 +2,7 @@
   <PropertyGroup>
     <PublishSingleFile>true</PublishSingleFile> 
 	  <PublishTrimmed>true</PublishTrimmed>
-	  <TrimMode>link</TrimMode>
+	  <TrimMode>partial</TrimMode>
     <OutputType>WinExe</OutputType>
     <Nullable>enable</Nullable>
     <BuiltInComInteropSupport>true</BuiltInComInteropSupport>

diff --git a/OmniConverter/Program.cs b/OmniConverter/Program.cs
@@ -13,8 +13,9 @@ namespace OmniConverter
     internal class Program
     {
         public static readonly string tempConvFile = "omniconv.temp";
-        public static readonly string tempConvFilePath = AppContext.BaseDirectory + $"/{tempConvFile}";
-        private static readonly string settingsPath = AppContext.BaseDirectory + "/settings.json";
+        public static readonly string tempConvFilePath = $"{AppDomain.CurrentDomain.BaseDirectory}/{tempConvFile}";
+        private static readonly string settingsPath = $"{AppDomain.CurrentDomain.BaseDirectory}/settings.json";
+
         public static Settings Settings { get; private set; } = new();
         public static SoundFonts SoundFontsManager { get; private set; } = new();
         public static bool FFmpegAvailable { get; private set; } = false;
@@ -111,7 +112,7 @@ public static void LoadConfig(bool startup = false)
                 using (StreamReader sr = new(settingsPath))
                     settingsJSON = sr.ReadToEnd();
 
-                var jsonSettings = new JsonSerializerSettings { MissingMemberHandling = MissingMemberHandling.Ignore };
+                var jsonSettings = new JsonSerializerSettings { MissingMemberHandling = MissingMemberHandling.Ignore, NullValueHandling = NullValueHandling.Ignore };
                 var userSettings = JsonConvert.DeserializeObject<Settings?>(settingsJSON, jsonSettings);
 
                 if (userSettings == null)
@@ -122,8 +123,9 @@ public static void LoadConfig(bool startup = false)
 
                 Settings = userSettings;
             }
-            catch
+            catch (Exception ex)
             {
+                Debug.PrintToConsole(Debug.LogType.Warning, $"Something went wrong while opening the file! {ex.Message}");
                 CreateConfig(startup);
             }
             finally