New Onboarding Flow #482

BlowaterNostr · 2024-06-20T09:39:46Z

This PR implements

without the invitation button

BlowaterNostr · 2024-06-20T09:58:53Z

app/UI/space-drop-down-panel.tsx

Rename from relay-switch to space-drop-down

BlowaterNostr · 2024-06-20T09:59:50Z

app/UI/sign-in.tsx

-    } | {
-        type: "backup";
-        name: string;
+        type: "create-key";


remove name step

rename backup to create-key to better describe the intention

BlowaterNostr · 2024-06-20T10:01:00Z

app/UI/nav.tsx

-    relay: SingleRelayConnection;
+export type SelectSpace = {
+    type: "SelectSpace";
+    spaceURL: string;


rename from relay to space

use url instead of the connection instance to reduce dependencies

BlowaterNostr · 2024-06-20T10:01:57Z

app/UI/relay-detail.tsx

@@ -202,6 +202,7 @@ export class RelayInformationComponent extends Component<Props, State> {
                const pubkey = PublicKey.FromString(info.pubkey);
                if (pubkey instanceof Error) {
                    // todo make a UI
+                    console.log(info);


In the future, maye the next PR, we need to use zed to runtime valid JSON shapes to prevent incorrect data from the server

We get a {pubkey: {hex: "xxx"}} from relayed

BlowaterNostr · 2024-06-20T10:02:30Z

app/UI/setting.tsx

-export type ViewRelayDetail = {
-    type: "ViewRelayDetail";
+export type ViewSpaceSettings = {
+    type: "ViewSpaceSettings";


BlowaterNostr

@bob2402 please review

app/UI/space-drop-down-panel.tsx

bob2402 · 2024-06-21T07:58:22Z

app/UI/space-drop-down-panel.tsx

+            <svg
+                class="w-6 h-6 mr-2"
+                width="14"
+                height="14"
+                viewBox="0 0 14 14"
+                fill="none"
+                xmlns="http://www.w3.org/2000/svg"
+            >
+                <path
+                    d="M7.00003 4.00003C6.40668 4.00003 5.82667 4.17598 5.33332 4.50562C4.83997 4.83526 4.45545 5.3038 4.22839 5.85198C4.00133 6.40016 3.94192 7.00336 4.05767 7.5853C4.17343 8.16724 4.45915 8.70179 4.87871 9.12135C5.29827 9.54091 5.83281 9.82663 6.41476 9.94238C6.9967 10.0581 7.5999 9.99873 8.14808 9.77167C8.69626 9.5446 9.16479 9.16009 9.49444 8.66674C9.82408 8.17339 10 7.59337 10 7.00003C9.9992 6.20463 9.68287 5.44205 9.12044 4.87962C8.55801 4.31719 7.79542 4.00086 7.00003 4.00003ZM7.00003 9.00003C6.60447 9.00003 6.21779 8.88273 5.88889 8.66297C5.55999 8.4432 5.30364 8.13085 5.15227 7.7654C5.00089 7.39994 4.96129 6.99781 5.03846 6.60985C5.11563 6.22189 5.30611 5.86552 5.58581 5.58581C5.86552 5.30611 6.22189 5.11563 6.60985 5.03846C6.99781 4.96129 7.39994 5.00089 7.7654 5.15227C8.13085 5.30364 8.4432 5.55999 8.66297 5.88889C8.88273 6.21779 9.00003 6.60447 9.00003 7.00003C9.00003 7.53046 8.78931 8.03917 8.41424 8.41424C8.03917 8.78931 7.53046 9.00003 7.00003 9.00003ZM12.5 7.13503C12.5025 7.04503 12.5025 6.95503 12.5 6.86503L13.4325 5.70003C13.4814 5.63886 13.5153 5.56706 13.5313 5.49042C13.5474 5.41378 13.5452 5.33443 13.525 5.25878C13.3722 4.68415 13.1435 4.13243 12.845 3.61815C12.806 3.55085 12.7517 3.4936 12.6866 3.45096C12.6215 3.40832 12.5473 3.38146 12.47 3.37253L10.9875 3.20753C10.9259 3.14253 10.8634 3.08003 10.8 3.02003L10.625 1.53378C10.616 1.45641 10.5891 1.38222 10.5463 1.31711C10.5036 1.252 10.4462 1.19779 10.3788 1.15878C9.8643 0.86087 9.31263 0.632425 8.73815 0.479404C8.66245 0.459277 8.58308 0.457218 8.50643 0.473394C8.42979 0.489569 8.35802 0.523527 8.2969 0.572529L7.13503 1.50003C7.04503 1.50003 6.95503 1.50003 6.86503 1.50003L5.70003 0.569404C5.63886 0.520509 5.56706 0.486665 5.49042 0.470598C5.41378 0.454531 5.33443 0.456691 5.25878 0.476903C4.68425 0.630045 4.13256 0.858705 3.61815 1.1569C3.55085 1.19598 3.4936 1.25023 3.45096 1.31533C3.40832 1.38044 3.38146 1.45459 3.37253 1.5319L3.20753 3.0169C3.14253 3.07899 3.08003 3.14149 3.02003 3.2044L1.53378 3.37503C1.45641 3.38403 1.38222 3.41098 1.31711 3.45373C1.252 3.49649 1.19779 3.55386 1.15878 3.62128C0.86087 4.13576 0.632425 4.68743 0.479404 5.2619C0.459277 5.33761 0.457218 5.41698 0.473394 5.49362C0.489569 5.57027 0.523527 5.64204 0.572529 5.70315L1.50003 6.86503C1.50003 6.95503 1.50003 7.04503 1.50003 7.13503L0.569404 8.30003C0.520509 8.3612 0.486665 8.43299 0.470598 8.50964C0.454531 8.58628 0.456691 8.66562 0.476903 8.74128C0.629772 9.3159 0.858447 9.86762 1.1569 10.3819C1.19598 10.4492 1.25023 10.5065 1.31533 10.5491C1.38044 10.5917 1.45459 10.6186 1.5319 10.6275L3.0144 10.7925C3.07649 10.8575 3.13899 10.92 3.2019 10.98L3.37503 12.4663C3.38403 12.5436 3.41098 12.6178 3.45373 12.6829C3.49649 12.7481 3.55386 12.8023 3.62128 12.8413C4.13576 13.1392 4.68743 13.3676 5.2619 13.5207C5.33761 13.5408 5.41698 13.5428 5.49362 13.5267C5.57027 13.5105 5.64204 13.4765 5.70315 13.4275L6.86503 12.5C6.95503 12.5025 7.04503 12.5025 7.13503 12.5L8.30003 13.4325C8.3612 13.4814 8.43299 13.5153 8.50964 13.5313C8.58628 13.5474 8.66562 13.5452 8.74128 13.525C9.3159 13.3722 9.86762 13.1435 10.3819 12.845C10.4492 12.806 10.5065 12.7517 10.5491 12.6866C10.5917 12.6215 10.6186 12.5473 10.6275 12.47L10.7925 10.9875C10.8575 10.9259 10.92 10.8634 10.98 10.8L12.4663 10.625C12.5436 10.616 12.6178 10.5891 12.6829 10.5463C12.7481 10.5036 12.8023 10.4462 12.8413 10.3788C13.1392 9.8643 13.3676 9.31263 13.5207 8.73815C13.5408 8.66245 13.5428 8.58308 13.5267 8.50643C13.5105 8.42979 13.4765 8.35802 13.4275 8.2969L12.5 7.13503ZM11.4938 6.72878C11.5044 6.90946 11.5044 7.0906 11.4938 7.27128C11.4863 7.39498 11.5251 7.51703 11.6025 7.61378L12.4894 8.7219C12.3876 9.04532 12.2573 9.35905 12.1 9.6594L10.6875 9.8194C10.5645 9.83306 10.4509 9.89185 10.3688 9.9844C10.2485 10.1197 10.1203 10.2478 9.98503 10.3682C9.89247 10.4503 9.83368 10.5639 9.82003 10.6869L9.66315 12.0982C9.36284 12.2555 9.0491 12.3858 8.72565 12.4875L7.6169 11.6007C7.52818 11.5298 7.41797 11.4912 7.3044 11.4913H7.2744C7.09373 11.5019 6.91258 11.5019 6.7319 11.4913C6.60821 11.4838 6.48615 11.5226 6.3894 11.6L5.27815 12.4875C4.95474 12.3858 4.641 12.2555 4.34065 12.0982L4.18065 10.6875C4.167 10.5645 4.10821 10.4509 4.01565 10.3688C3.88035 10.2485 3.75221 10.1203 3.6319 9.98503C3.54974 9.89247 3.43616 9.83368 3.31315 9.82003L1.9019 9.66253C1.74452 9.36222 1.61422 9.04847 1.51253 8.72503L2.3994 7.61628C2.47684 7.51953 2.5156 7.39748 2.50815 7.27378C2.49753 7.0931 2.49753 6.91196 2.50815 6.73128C2.5156 6.60758 2.47684 6.48552 2.3994 6.38878L1.51253 5.27815C1.61429 4.95474 1.7446 4.641 1.9019 4.34065L3.31253 4.18065C3.43554 4.167 3.54911 4.10821 3.63128 4.01565C3.75159 3.88035 3.87972 3.75221 4.01503 3.6319C4.10795 3.54968 4.16698 3.43585 4.18065 3.31253L4.33753 1.9019C4.63784 1.74452 4.95158 1.61422 5.27503 1.51253L6.38378 2.3994C6.48052 2.47684 6.60258 2.5156 6.72628 2.50815C6.90696 2.49753 7.0881 2.49753 7.26878 2.50815C7.39248 2.5156 7.51453 2.47684 7.61128 2.3994L8.7219 1.51253C9.04532 1.61429 9.35905 1.7446 9.6594 1.9019L9.8194 3.31253C9.83306 3.43554 9.89185 3.54911 9.9844 3.63128C10.1197 3.75159 10.2478 3.87972 10.3682 4.01503C10.4503 4.10758 10.5639 4.16637 10.6869 4.18003L12.0982 4.3369C12.2555 4.63722 12.3858 4.95096 12.4875 5.2744L11.6007 6.38315C11.5225 6.48071 11.4837 6.60403 11.4919 6.72878H11.4938Z"


Putting the icon in UI/icons is better.

The only problem is that I am not sure much reusable this piece of UI is at this moment. We can do the abstraction later.

app/UI/space-drop-down-panel.test.tsx

Co-authored-by: Bob <160986752+bob2402@users.noreply.github.com>

BlowaterNostr added 6 commits June 20, 2024 01:16

Update tauri.conf.json

4fdb398

Update sign-in.tsx

e826898

rename

c79f946

Update space-drop-down-panel.tsx

3806bdb

Update space-drop-down-panel.tsx

2a19a59

Update space-drop-down-panel.tsx

e7cd4d8

deno-deploy bot deployed to Preview June 20, 2024 09:40 View deployment

BlowaterNostr marked this pull request as draft June 20, 2024 09:40

BlowaterNostr changed the title ~~New onboarding~~ New Onboarding Flow Jun 20, 2024

view space settings from drop down panel

1079a3a

deno-deploy bot deployed to Preview June 20, 2024 09:48 View deployment

Update space-drop-down-panel.tsx

bdcd4eb

deno-deploy bot deployed to Preview June 20, 2024 09:56 View deployment

BlowaterNostr marked this pull request as ready for review June 20, 2024 09:56

BlowaterNostr commented Jun 20, 2024

View reviewed changes

app/UI/space-drop-down-panel.tsx

Copy link

Owner Author

BlowaterNostr Jun 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename from relay-switch to space-drop-down

BlowaterNostr commented Jun 20, 2024

View reviewed changes

bob2402 reviewed Jun 21, 2024

View reviewed changes

app/UI/space-drop-down-panel.tsx Outdated Show resolved Hide resolved

bob2402 reviewed Jun 21, 2024

View reviewed changes

app/UI/space-drop-down-panel.tsx Outdated Show resolved Hide resolved

bob2402 reviewed Jun 21, 2024

View reviewed changes

app/UI/space-drop-down-panel.test.tsx Outdated Show resolved Hide resolved

Apply suggestions from code review

9d3e3a2

Co-authored-by: Bob <160986752+bob2402@users.noreply.github.com>

deno-deploy bot deployed to Preview June 21, 2024 10:38 View deployment

Update nostr.ts

6c2fab0

deno-deploy bot deployed to Preview June 21, 2024 10:42 View deployment

Update space-drop-down-panel.test.tsx

86180c8

deno-deploy bot deployed to Preview June 21, 2024 10:44 View deployment

Update space-drop-down-panel.tsx

ff4c6ee

deno-deploy bot deployed to Preview June 21, 2024 17:03 View deployment

BlowaterNostr merged commit 1e37e20 into main Jun 21, 2024
4 checks passed

BlowaterNostr deleted the new-onboarding branch June 21, 2024 17:05

bob2402 restored the new-onboarding branch June 22, 2024 00:28

bob2402 deleted the new-onboarding branch June 22, 2024 00:28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New Onboarding Flow #482

New Onboarding Flow #482

BlowaterNostr commented Jun 20, 2024 •

edited

Loading

BlowaterNostr Jun 20, 2024

BlowaterNostr Jun 20, 2024

BlowaterNostr Jun 20, 2024

BlowaterNostr Jun 20, 2024

BlowaterNostr Jun 20, 2024

BlowaterNostr Jun 20, 2024

BlowaterNostr left a comment

bob2402 Jun 21, 2024

BlowaterNostr Jun 21, 2024

New Onboarding Flow #482

New Onboarding Flow #482

Conversation

BlowaterNostr commented Jun 20, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

BlowaterNostr left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

BlowaterNostr commented Jun 20, 2024 •

edited

Loading