Merge upstream google fork #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, Neuroglancer used a complicated mechanism to attempt to determine the region of a bucket, but this mechanism did not work. However, it turns out it was unnecessary because all buckets can instead be accessed using `<bucket>.s3.amazonaws.com` regardless of region. Fixes #418
This option controls whether segments are highlighted on hover. This also fixes the hover highlighting of segment 0, which was previously not handled correctly (no hover segment was treated as segment 0 equal to the hover segment).
Previously, the precomputed, zarr, and n5 drivers treated missing chunks as errors. This had two consequences: - screenshots would hang due to failed chunks - chunks were not correctly displayed as the fill value (usually 0) With this commit, missing chunks are treated as containing the fill value (only zarr supports a non-zero fill value). Fixes #422
Previously, a client state update made concurrently with a server state update could cause the server state update to be lost. With this change, server state updates always take priority. This is also expected to improve the reliability of the webdriver-based tests.
…nAnnotationSpacing changes Fixes #421
Previously, requests with credentials were retried but other requests were not retried.
… to spurious errors
…equests Previously, the Neuroglancer client (running the browser) could incorrectly send additional state updates to the Python server even while an existing state update was still in progress, if the server response time is longer than the update interval. This lead to client state updates being lost.
The new Ubuntu 22.04 runner does not include Firefox.
Per karma-runner/karma-firefox-launcher#183, the snap version of firefox does not work with Karma.
…pping If a ChunkSource was destroyed while a chunk update was enqueued, the chunk queue update processing would stop.
This allows build information to be added to the help panel.
…ather than waiting for response to return full mouse control to the user (#443)
Previously, Neuroglancer did not take into account that OME treats the center of a pixel as its origin, while Neuroglancer treats the corner as the origin. Fixes #440.
…er is deleted (#669) removed disposed method on SharedDisjointUint64Sets to prevent potential "cannot read properties of undefined" errors as garbage collection benefit is likely insignificant
* ome.ts: update with dev2 version from the ngff challenge The current proposal for updating OME-Zarr to support Zarr v3 wraps the NGFF metadata in the Zarr metadata within an "ome" block. This checks for that block and if it exists unwraps the necessary metadata. This format is **not** finalized. see: https://forum.image.sc/t/ome2024-ngff-challenge/97363 * Check zarrVersion rather than ome's definition * Raise exception rather than check version * Also update frontend * Fix formatting * Fix format with prettier --------- Co-authored-by: Norman Rzepka <code@normanrz.com>
This is expected to be faster and also reduces the bundle size.
This was accidentally broken by the change to use `CompressionStream`. Fixes #679.
CancellationToken was introduced before `AbortSignal` was supported by browsers. This commit also unifies handling of authentication status messages and popup windows. Some features previously supported only for middleauth are now supported for all credential providers: - Display authentication status message in "modal" mode by default - Detecting when authentication popup window is closed - Closing the popup if the user navigates away from the page without completing authentication.
This aligns with native JavaScript class properties and improves compatibility with other transpilers/bundlers, like swc and rspack, like that can have varying behavior when `useDefineForClassFields=false`.
This avoids the possibility of hangs when requesting a chunk via the Python API that is already in a FAILED state.
Previously, the playback toggle button in the position widget dropdown did not correctly toggle the display of the playback controls.
Previously, the position widget did not correctly perform dimension indexing when in single-dimension mode (as used only for the DimensionTool). In particular, it always displayed the position of the first dimension, rather than the dimension actually selected.
Previously, panels that were scrolled out of view were not correctly tracked.
Previously, the position widget displayed "undefined" and other undesirable text until the CoordinateSpace is marked `valid` (i.e. at least one data source loads).
Tool palettes are additional side panels that contain tools added from any number of layers.
This avoids pulling in unnecessary transitive dependencies, and avoids issues the vite dev-server has with transitive CommonJS dependencies.
…nstall The vite examples previously worked only when using a symlinked Neuroglancer (as in the tests used in this repo), but not when the Neuroglancer dependency was installed normally. The vite dev server special-cases symlinked dependencies in a way that made its optimizeDeps step work when Neuroglancer is symlinked in `node_modules` but not otherwise. Additional optimizeDeps options have now been added to the vite example configs to ensure the build works when Neuroglancer is installed as a normal dependency. Fixes #683
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.