Fix glob pattern to correctly ignore directories with only dots #3019
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #2990, where
ripgrep
did not properly ignore directories named only with dots (e.g.,.
,..
,...
) when using negated glob patterns (-g '!dir'
).Previously, the
file_name
function inglobset
only checked if the last byte was a dot (.
), which led to incorrect behavior. This caused:rg --files -g '!asdf.'
still listingasdf./foo
rg --files -g '!asdf'
correctly ignoringasdf/foo
Fix
The function now ensures that entire filenames made only of dots are ignored by using: