-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deploy | CAKK-53 | v2.0.4 배포 #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Feature | CAKK-58 | User Command 관련 Facade 구현 * Refactor | CAKK-58 | 미사용 Writer 삭제 * Refactor | CAKK-58 | Service 레이어에 Facade 패턴 적용 * Test | CAKK-58 | Facade 테스트 추상 클래스 구축 및 테스트 작성
* Chore | CAKK-58 | kt dsl 적용 및 kotlin 의존성 주입 * Rename .java to .kt * Refactor | CAKK-58 | send 관련 코틀린 적용 및 추상화 * Refactor | CAKK-58 | 사업자 인증 관련 리팩토링 * Refactor | CAKK-58 | 이메일 인증 관련 리팩토링 * Refactor | CAKK-58 | 함수형 인터페이스로 수정 * Refactor | CAKK-58 | 파라미터 수정 * Refactor | CAKK-58 | 템플릿 콜백 패턴 적 * Refactor | CAKK-58 | 템플릿 콜백 패턴 적용
* Refactor | CAKK-59 | MessageExtractor 인터페이스 추상화 * Refactor | CAKK-59 | as-is 클래스 및 인터페이스 제거 * Refactor | CAKK-59 | as-is 클래스 및 인터페이스 제거 * Refactor | CAKK-59 | 메시지 extractor, template 추상화 * Refactor | CAKK-59 | 에러 메시지 리스너 구현 * Refactor | CAKK-59 | api 모듈 slack 의존성 제거 * Refactor | CAKK-59 | 메시지 관련 비즈니스 리팩토링 * Test | CAKK-59 | 메시지 전송 관련 테스트 수정 * Chore | CAKK-59 | jacoco exclude에 리스너 등록 * Refactor | CAKK-59 | email 관련 sender 네이밍 수정 * Refactor | CAKK-59 | 제네릭 범위 수정 * Test | CAKK-59 | Error 관련 리스너 테스트 작성
* Chore | CAKK-61 | mail 및 slack 의존성 추가 * Refactor | CAKK-61 | Dip 위반 문제 해결
Refactor | CAKK-57 | 케이크 도메인 로직 리팩토링
* Rename .java to .kt * Refactor | CAKK-62 | kotlin으로 전환 * Test | CAKK-62 | 테스트 코드 수정
* Refactor | CAKK-63 | UserCommandFacade 네이밍 수정 * Refactor | CAKK-63 | Facade 패턴 적용 * Refactor | CAKK-63 | Writer 제거
* Rename .java to .kt * Refactor | CAKK-65 | kt 전환 * Refactor | CAKK-65 | kt 전환에 따른 수정 * Refactor | CAKK-65 | lombok 제거
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## master #207 +/- ##
============================================
- Coverage 93.57% 92.33% -1.24%
+ Complexity 332 330 -2
============================================
Files 109 109
Lines 965 966 +1
Branches 34 34
============================================
- Hits 903 892 -11
- Misses 46 58 +12
Partials 16 16
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CAKK-53