Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor | CAKK-80 | core 모듈 생성 및 Facade 이관 #208

Merged
merged 4 commits into from
Sep 13, 2024

Conversation

lcomment
Copy link
Collaborator

Issue Number

CAKK-80

Description

  • core 모듈 생성
  • Facade 이관

etc

@lcomment lcomment added the refactor 비즈니스 변경 없는 수정 label Sep 13, 2024
@lcomment lcomment requested a review from YongsHub September 13, 2024 07:28
@lcomment lcomment self-assigned this Sep 13, 2024
Copy link

Test Results

 40 files  ±0   40 suites  ±0   23s ⏱️ ±0s
215 tests ±0  215 ✅ ±0  0 💤 ±0  0 ❌ ±0 
216 runs  ±0  216 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 781704c. ± Comparison against base commit 4c8ec2a.

Copy link

codecov bot commented Sep 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Impacted file tree graph

@@              Coverage Diff              @@
##             develop     #208      +/-   ##
=============================================
+ Coverage      92.33%   93.16%   +0.82%     
- Complexity       330      331       +1     
=============================================
  Files            109      109              
  Lines            966      966              
  Branches          34       34              
=============================================
+ Hits             892      900       +8     
+ Misses            58       48      -10     
- Partials          16       18       +2     
Files with missing lines Coverage Δ Complexity Δ
.../java/com/cakk/api/config/ComponentScanConfig.java 100.00% <ø> (ø) 1.00 <0.00> (ø)
...in/java/com/cakk/api/service/cake/CakeService.java 97.14% <100.00%> (ø) 10.00 <0.00> (ø)
...n/java/com/cakk/api/service/like/HeartService.java 100.00% <ø> (ø) 6.00 <0.00> (ø)
...in/java/com/cakk/api/service/like/LikeService.java 100.00% <ø> (ø) 1.00 <0.00> (ø)
...in/java/com/cakk/api/service/shop/ShopService.java 98.59% <100.00%> (ø) 20.00 <0.00> (ø)
...in/java/com/cakk/api/service/user/SignService.java 100.00% <100.00%> (ø) 5.00 <0.00> (ø)
...in/java/com/cakk/api/service/user/UserService.java 100.00% <100.00%> (ø) 3.00 <0.00> (ø)

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c8ec2a...781704c. Read the comment docs.

@lcomment lcomment merged commit f2aa133 into develop Sep 13, 2024
3 checks passed
@lcomment lcomment deleted the refactor/CAKK-80 branch September 13, 2024 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor 비즈니스 변경 없는 수정
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants