Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor | CAKK-81 | External 모듈, Client 모듈 통합 #209

Merged
merged 4 commits into from
Sep 13, 2024

Conversation

lcomment
Copy link
Collaborator

Issue Number

CAKK-81

Description

External 모듈, Client 모듈 통합

etc

@lcomment lcomment added the refactor 비즈니스 변경 없는 수정 label Sep 13, 2024
@lcomment lcomment requested a review from YongsHub September 13, 2024 08:29
@lcomment lcomment self-assigned this Sep 13, 2024
Copy link

github-actions bot commented Sep 13, 2024

Test Results

 40 files   40 suites   25s ⏱️
215 tests 215 ✅ 0 💤 0 ❌
216 runs  216 ✅ 0 💤 0 ❌

Results for commit 0d4e0c6.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@YongsHub YongsHub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다

Copy link

codecov bot commented Sep 13, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...com/cakk/api/provider/oauth/PublicKeyProvider.java 0.00% 3 Missing ⚠️

Impacted file tree graph

@@              Coverage Diff              @@
##             develop     #209      +/-   ##
=============================================
+ Coverage      92.11%   93.37%   +1.25%     
- Complexity       329      332       +3     
=============================================
  Files            109      109              
  Lines            964      966       +2     
  Branches          34       34              
=============================================
+ Hits             888      902      +14     
+ Misses            57       47      -10     
+ Partials          19       17       -2     
Files with missing lines Coverage Δ Complexity Δ
...va/com/cakk/api/controller/s3/AwsS3Controller.java 100.00% <ø> (ø) 1.00 <0.00> (ø)
.../cakk/api/listener/CertificationEventListener.java 100.00% <ø> (ø) 2.00 <0.00> (ø)
.../com/cakk/api/listener/EmailSendEventListener.java 100.00% <ø> (ø) 2.00 <0.00> (ø)
...com/cakk/api/listener/ErrorAlertEventListener.java 100.00% <ø> (ø) 2.00 <0.00> (ø)
...src/main/java/com/cakk/api/mapper/EventMapper.java 96.55% <ø> (+0.25%) 6.00 <0.00> (ø)
...akk/api/provider/oauth/impl/AppleAuthProvider.java 100.00% <ø> (ø) 1.00 <0.00> (ø)
...akk/api/provider/oauth/impl/KakaoAuthProvider.java 100.00% <ø> (ø) 1.00 <0.00> (ø)
...com/cakk/api/provider/oauth/PublicKeyProvider.java 11.11% <0.00%> (ø) 1.00 <0.00> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2aa133...0d4e0c6. Read the comment docs.

@lcomment lcomment merged commit 23d2974 into develop Sep 13, 2024
2 of 3 checks passed
@lcomment lcomment deleted the refactor/CAKK-81 branch September 13, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor 비즈니스 변경 없는 수정
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants