Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy | CAKK-96 | v2.0.6 배포 #225

Merged
merged 4 commits into from
Oct 31, 2024
Merged

Deploy | CAKK-96 | v2.0.6 배포 #225

merged 4 commits into from
Oct 31, 2024

Conversation

lcomment
Copy link
Collaborator

Issue Number

CAKK-96

Description

  • 3km 내 검색 유효성 체크 수정

etc

lcomment and others added 4 commits October 1, 2024 22:09
* Refactor | CAKK-91 | 의존성 관련 리팩토링

* Test | CAKK-91 | 리팩토링에 따른 테스트 코드 수정
* Chore | CAKK-92 | Security 관련 의존성 추가

* Feature | CAKK-92 | 인증 어드민 관련 기능 구현

* Refactor | CAKK-92 | 어드민 서버 코드 리팩토링
* Refactor | CAKK-94 | 카테고리 별 이미지 조회 시,  샵 이름과 썸네일 이미지 조회 추가

* Refactor | CAKK-94 | 조회 리팩토링으로 인한 애플리케이션 로직 수정

* Test | CAKK-94 | 테스트 수정

* Fix | CAKK-94 | 케이크 이미지 다량 조회 시, return 값 변경

* Test | CAKK-94 | 코드 수정에 의한 테스트 코드 수정

* Fix | CAKK-94 | 필요 없는 dto 제거
@lcomment lcomment added the fix 비즈니스 로직 수정 label Oct 30, 2024
@lcomment lcomment requested a review from YongsHub October 30, 2024 06:37
@lcomment lcomment self-assigned this Oct 30, 2024
Copy link

Test Results

212 tests  +74   212 ✅ +74   46s ⏱️ +8s
 40 suites +16     0 💤 ± 0 
 40 files   +16     0 ❌ ± 0 

Results for commit c88aa9e. ± Comparison against base commit c6d29b6.

Copy link

codecov bot commented Oct 30, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
.../src/main/kotlin/com/cakk/api/mapper/ShopMapper.kt 0.00% 0 Missing and 2 partials ⚠️

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #225      +/-   ##
============================================
- Coverage     91.00%   90.19%   -0.81%     
  Complexity      235      235              
============================================
  Files            59       59              
  Lines           589      612      +23     
  Branches         17       17              
============================================
+ Hits            536      552      +16     
- Misses           44       51       +7     
  Partials          9        9              
Files with missing lines Coverage Δ Complexity Δ
...lin/com/cakk/api/controller/cake/CakeController.kt 100.00% <ø> (ø) 11.00 <0.00> (ø)
...pi/dto/request/shop/SearchShopByLocationRequest.kt 100.00% <100.00%> (ø) 1.00 <0.00> (ø)
.../src/main/kotlin/com/cakk/api/mapper/ShopMapper.kt 92.68% <0.00%> (ø) 0.00 <0.00> (ø)

... and 17 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d91c5d...c88aa9e. Read the comment docs.

@lcomment lcomment merged commit 7d6049f into master Oct 31, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix 비즈니스 로직 수정
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants