Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix | CAKK-100 | 거리 검색 10km로 확장 #227

Merged
merged 1 commit into from
Dec 8, 2024
Merged

Conversation

lcomment
Copy link
Collaborator

@lcomment lcomment commented Dec 8, 2024

Issue Number

CAKK-100

Description

  • 거리 검색 10km로 확장

Core Code

data class SearchShopByLocationRequest(
	@field:NotNull @field:Min(-90) @field:Max(90)
    val latitude: Double?,
	@field:NotNull @field:Min(-180) @field:Max(180)
    val longitude: Double?,
	@field:Min(0) @field:Max(10000)
    val distance: Double? = 1000.0
)

etc

@lcomment lcomment added the fix 비즈니스 로직 수정 label Dec 8, 2024
@lcomment lcomment requested a review from YongsHub December 8, 2024 06:48
@lcomment lcomment self-assigned this Dec 8, 2024
Copy link

github-actions bot commented Dec 8, 2024

Test Results

212 tests   212 ✅  46s ⏱️
 40 suites    0 💤
 40 files      0 ❌

Results for commit 1ab5f2b.

Copy link

codecov bot commented Dec 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Impacted file tree graph

@@              Coverage Diff              @@
##             develop     #227      +/-   ##
=============================================
- Coverage      92.14%   90.19%   -1.95%     
+ Complexity       329      238      -91     
=============================================
  Files            109       59      -50     
  Lines            967      612     -355     
  Branches          34       17      -17     
=============================================
- Hits             891      552     -339     
+ Misses            58       51       -7     
+ Partials          18        9       -9     
Files with missing lines Coverage Δ Complexity Δ
...pi/dto/request/shop/SearchShopByLocationRequest.kt 100.00% <100.00%> (ø) 4.00 <1.00> (?)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a2439a...1ab5f2b. Read the comment docs.

@lcomment lcomment merged commit b0def28 into develop Dec 8, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix 비즈니스 로직 수정
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants