Skip to content

Fix tests #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 15, 2025
Merged

Fix tests #77

merged 6 commits into from
May 15, 2025

Conversation

kelly-sovacool
Copy link
Member

@kelly-sovacool kelly-sovacool commented May 13, 2025

Changes

A couple of tests that use subprocess.run started failing within the last couple of days even though the code didn't change. They succeed locally but fail in github actions.

=========================== short test summary info ============================
FAILED tests/test_cli.py::test_version_cmd - AssertionError: assert False
 +  where False = <built-in method startswith of str object at 0x7f8835bf88f0>('VERSION file path')
 +    where <built-in method startswith of str object at 0x7f8835bf88f0> = '0.3.2-dev\n'.startswith
FAILED tests/test_cli.py::test_send_email - subprocess.CalledProcessError: Command 'ccbr_tools send-email -d' returned non-zero exit status 1.
============ 2 failed, 105 passed, 2 skipped, 4 warnings in 21.43s =============

Issues

PR Checklist

(Strikethrough any points that are not applicable.)

  • This comment contains a description of changes with justifications, with any relevant issues linked.
  • [ ] Write unit tests for any new features, bug fixes, or other code changes.
  • [ ] Update docs if there are any API changes.
  • [ ] Update CHANGELOG.md with a short description of any user-facing changes and reference the PR number. Guidelines: https://keepachangelog.com/en/1.1.0/

Copy link

codecov bot commented May 15, 2025

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 73.79%. Comparing base (7fc89d2) to head (4f871b2).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
src/ccbr_tools/send_email.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #77      +/-   ##
==========================================
- Coverage   74.05%   73.79%   -0.27%     
==========================================
  Files          22       22              
  Lines        1588     1595       +7     
==========================================
+ Hits         1176     1177       +1     
- Misses        412      418       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kelly-sovacool kelly-sovacool marked this pull request as ready for review May 15, 2025 20:56
@kelly-sovacool kelly-sovacool merged commit 3713f8d into main May 15, 2025
9 of 11 checks passed
@kelly-sovacool kelly-sovacool deleted the fix-tests branch May 15, 2025 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant