-
-
Notifications
You must be signed in to change notification settings - Fork 2
Create a backend endpoint to search students by name #31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few minor comments.
Can you also add tests for this? I think I set up a test database that you can use, so you should be able to add students to it in a beforeAll
and do a clean up afterAll
I had to comment out one line of code in the Meeting model because the test cases were failing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes are looking good! Just left a couple comments about moving database setup and teardown and then it should be good to go
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect! Thank you!
What type of PR is this? (check all applicable)
Description
This PR adds a backend endpoint
GET /api/students
that supports optional query parameters name and email for filtering students by partial matches. If no parameters are provided, it returns all students.Related Tickets & Documents
Fixes #25
Mobile & Desktop Screenshots/Recordings
Added tests?
Added to documentation?
[optional] Are there any post-deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?