feat: fix direct update delay #555
Conversation
WalkthroughThe pull request adds logic to delay the update process based on configured conditions. The update method now retrieves a JSON string from shared preferences, parses it using the Gson library into an array of Changes
Sequence Diagram(s)sequenceDiagram
participant U as Update Process
participant P as CapacitorUpdaterPlugin
participant SP as SharedPreferences
participant G as Gson Parser
participant N as Notification System
U->>P: Invoke backgroundDownload()
P->>SP: Retrieve JSON string for DelayConditions
SP-->>P: Return JSON string
P->>G: Parse JSON to DelayConditions array
G-->>P: Return DelayConditions array
alt DelayConditions present
P->>N: Call endBackGroundTaskWithNotif()
N-->>P: Notify user update delayed
else No DelayConditions
P->>U: Continue update process
end
Poem
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
android/src/main/java/ee/forgr/capacitor_updater/CapacitorUpdaterPlugin.java (1)
61-61: Consider using a descriptive name for the preferences key.Using an empty string as the key for shared preferences is unusual and could potentially lead to conflicts with other preferences. Consider using a more descriptive name that includes the plugin name for better namespacing.
- private static final String DELAY_CONDITION_PREFERENCES = ""; + private static final String DELAY_CONDITION_PREFERENCES = "capacitor_updater_delay_conditions";
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
android/src/main/java/ee/forgr/capacitor_updater/CapacitorUpdaterPlugin.java(1 hunks)
🧰 Additional context used
🧬 Code Definitions (1)
android/src/main/java/ee/forgr/capacitor_updater/CapacitorUpdaterPlugin.java (2)
android/src/main/java/ee/forgr/capacitor_updater/CapacitorUpdater.java (1)
CapacitorUpdater(43-1074)src/definitions.ts (1)
CapacitorUpdaterPlugin(238-569)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: build_ios
🔇 Additional comments (2)
android/src/main/java/ee/forgr/capacitor_updater/CapacitorUpdaterPlugin.java (2)
1109-1122: LGTM! Properly implemented delay conditions check.The code correctly checks for delay conditions before proceeding with an update. When conditions are present, it appropriately notifies the user and stops the update process until those conditions are met.
1223-1230: Good consistency with delay condition handling.This code matches the implementation in the
backgroundDownloadmethod, ensuring delay conditions are consistently checked before proceeding with updates in both direct and background scenarios.
Summary by CodeRabbit