refactor network operations in NetworkMonitorPlugin #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refactors the network operations in the `NetworkMonitorPlugin` class The changes include the introduction of a new method, `remove_subnet_route_from_router`, to handle the removal of subnet routes from a router without removing the route, the network cleanup is raising the Exception ConflictException: 409: Client Error for url: <url>, Router interface for subnet on router cannot be deleted, as it is required by one or more routes. Change-Id: I7e35002ff2e471fe47601e9daea8cf77fe1a01df
Added extra test cases remove_subnet_route_from_router method to make sure it works Tested in UC dev Change-Id: I140b8d1897e941e088cfebc9433b8cc317bd7cb1
Mark-Powers
approved these changes
Dec 20, 2023
| return next_hop_ip in subnet_cidr | ||
| try: | ||
| subnet = neutron_client.show_subnet(subnet_id).get('subnet', {}) | ||
| except neutron_ex.NotFound as e: |
There was a problem hiding this comment.
Maybe I am forgetting something, but is there a point to these try/except blocks if the exception is just reraised? Should there at least be a log statement here.
There was a problem hiding this comment.
Good catch! I removed them for some reason, The logs should be there
Change-Id: I07cce45e92c8a08522994e6675ba5eeed184c37e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactors the network operations in the
NetworkMonitorPluginclass The changes include the introduction of a new method,remove_subnet_route_from_router, to handle the removal of subnet routes from a routerwithout removing the route, the network cleanup is raising the Exception
ConflictException: 409: Client Error for url: , Router interface for subnet on router cannot be deleted, as it is required by one or more routes.
Tested in UC dev by
Change-Id: I7e35002ff2e471fe47601e9daea8cf77fe1a01df