Use user token in external enforcement if not configured #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msherman64
approved these changes
Jul 23, 2024
There was a problem hiding this comment.
Looks good to me.
Calling out that the purpose of the "token" in this case is that the external enforcement service will use that token to authenticate to keystone.
So this token MUST be sent securely, and currently is the same token as blazar uses to authenticate to keystone.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In xena, we had this conditional code to fetch a user token https://github.com/ChameleonCloud/blazar/blob/chameleoncloud/xena/blazar/enforcement/filters/external_service_filter.py#L85-L86
This also gets the external identity endpoint, which is required because our "external service" is not in openstack.
Note: This breaks tests, as it tries to now reach out to keystone to get a token.