Fix lease get detail #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes the handling of the 'detail' parameter in the Blazar client show command. Since other resources like hosts and FIPs do not have a detail keyword in their manager get method, the previous implementation caused errors. This commit removes the unnecessary usage of 'detail' and instead calls the 'additional_details' method if the parsed args have 'detail' arg to fetch additional details Additionally, tests are added to cover the corrected behavior of the show command with and without the 'detail' parameter.
Mark-Powers
reviewed
Apr 15, 2024
| run: pip install tox | ||
|
|
||
| - name: Run tests | ||
| run: tox -e ${{ env.TOX_ENV }} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes the handling of the 'detail' parameter in the Blazar client show command. Since other resources like hosts and FIPs do not have a detail keyword in their manager get method, the previous implementation caused errors.
This commit removes the unnecessary usage of 'detail' and instead calls the 'additional_details' method if the parsed args have 'detail' arg to fetch additional details
Additionally, tests are added to cover the corrected behavior of the show command with and without the 'detail' parameter.