seventv: Made path regex compatible with new UIDs #699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brian6932
force-pushed
the
seventv/support-uuld
branch
3 times, most recently
from
e14e09f to
5e5d84c
Compare
|
Why would they do this |
brian6932
force-pushed
the
seventv/support-uuld
branch
from
5e5d84c to
6fbc2f7
Compare
brian6932
force-pushed
the
seventv/support-uuld
branch
from
6fbc2f7 to
4c264fe
Compare
pajlada
approved these changes
Oct 26, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #699 +/- ##
==========================================
+ Coverage 48.25% 48.92% +0.67%
==========================================
Files 109 109
Lines 3208 4100 +892
==========================================
+ Hits 1548 2006 +458
- Misses 1592 2025 +433
- Partials 68 69 +1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://togithub.com/ulid/spec/issues/94#issuecomment-1834520931
Pull request checklist:
CHANGELOG.mdwas updated, if applicableDescription
500test case, as that shouldn't be hit with the stricter regexes.