Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add unit tests for discord invite resolver #711

Merged
merged 4 commits into from
Nov 17, 2024

Conversation

pajlada
Copy link
Member

@pajlada pajlada commented Nov 17, 2024

Pull request checklist:

  • CHANGELOG.md was updated, if applicable

Description

The intent of this PR is just to add unit tests to the Discord invite resolver. However, as an unrelated change, we now sort the discord server features (Server Perks) alphabetically, this made testing it a bit easier and I don't think its a bad thing for it to be stable

Copy link

codecov bot commented Nov 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.01%. Comparing base (0406c4f) to head (fafdb9d).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #711      +/-   ##
==========================================
+ Coverage   48.92%   51.01%   +2.09%     
==========================================
  Files         109      109              
  Lines        4100     4118      +18     
==========================================
+ Hits         2006     2101      +95     
+ Misses       2025     1944      -81     
- Partials       69       73       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member Author

@pajlada pajlada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@pajlada pajlada merged commit fff4579 into master Nov 17, 2024
11 checks passed
@pajlada pajlada deleted the feat/add-unit-tests-for-discord-invite-resolver branch November 17, 2024 12:55
M4tthewDE pushed a commit to M4tthewDE/api that referenced this pull request Nov 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant