Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace github.com/golang/mock with go.uber.org/mock #712

Merged

Conversation

M4tthewDE
Copy link
Contributor

@M4tthewDE M4tthewDE commented Nov 17, 2024

Pull request checklist:

  • CHANGELOG.md was updated, if applicable

Description

github.com/golang/mock is deprecated

Copy link

codecov bot commented Nov 17, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 42 lines in your changes missing coverage. Please review.

Project coverage is 50.73%. Comparing base (fff4579) to head (8e4471e).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
internal/mocks/mock_dbPool.go 0.00% 42 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #712      +/-   ##
==========================================
- Coverage   51.01%   50.73%   -0.29%     
==========================================
  Files         109      109              
  Lines        4118     4141      +23     
==========================================
  Hits         2101     2101              
- Misses       1944     1967      +23     
  Partials       73       73              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pajlada pajlada merged commit 1d2e3ea into Chatterino:master Nov 17, 2024
9 of 11 checks passed
@M4tthewDE M4tthewDE deleted the feature/upgrade-gomock-with-uber-mock branch November 17, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants