Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix application_question.locator for payload #227

Open
wants to merge 44 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
44 commits
Select commit Hold shift + click to select a range
36f5852
Fix application_question.locator for payload
patanj101 Aug 8, 2024
f46f3f6
Fix application_question.locator for payload (remove byebug)
patanj101 Aug 8, 2024
3c4660f
created apply_to_job_spec
daniel-sussman Aug 8, 2024
33aa52c
Minor fixes for Bamboo
patanj101 Aug 8, 2024
31268ac
Workable: improvements & possibility to attach photo
patanj101 Aug 8, 2024
74cdbfe
Update question.option_text_values
patanj101 Aug 8, 2024
faef4c6
FieldsFormatter: DRY & Refactor attribute methods
patanj101 Aug 8, 2024
57d3224
FieldsFormatter: DRY & Refactor attribute methods (2)
patanj101 Aug 8, 2024
39f7cdc
Remove byebug
patanj101 Aug 8, 2024
8710538
apply_with_cheddar: fix
patanj101 Aug 8, 2024
2a034ff
Reset seeds.rb
patanj101 Aug 8, 2024
6dc9e26
rake task is functional except for date fields
daniel-sussman Aug 9, 2024
aa402f4
merged to branch
daniel-sussman Aug 9, 2024
616bc36
Formatter Ouput jsons update
patanj101 Aug 9, 2024
3c0e8ca
Formatter Ouput jsons delete
patanj101 Aug 9, 2024
0b83b89
Payload formatter to manage textarea and date format
patanj101 Aug 9, 2024
6f78152
updates to rake task
daniel-sussman Aug 9, 2024
0311e4e
merged branch
daniel-sussman Aug 9, 2024
a5ed9f5
Denied apply_with_cheddar for jobs with group type questions
patanj101 Aug 9, 2024
bbb0591
Prioritize Cover letter text over cover letter pdf
patanj101 Aug 9, 2024
e2c8167
Prioritize Cover letter text over cover letter pdf
patanj101 Aug 9, 2024
55f92e7
fix to ashby_form_filler
daniel-sussman Aug 9, 2024
eb5cbc0
merged to branch
daniel-sussman Aug 9, 2024
0b012bb
added full list of FormFillers to ApplyToJob
daniel-sussman Aug 9, 2024
33f16ec
Update converted_type for interaction purpose
patanj101 Aug 9, 2024
32de85d
Step back from formatted_answered_value
patanj101 Aug 9, 2024
5083aa1
Improve value output for payload
patanj101 Aug 9, 2024
86404b3
ApplicationSubmission: Fix ApplyJob call
patanj101 Aug 9, 2024
bc0d676
fixed apply_url with old_format greenhouse jobs
daniel-sussman Aug 12, 2024
2e37eda
fixed it properly this time
daniel-sussman Aug 12, 2024
673c2d4
tests:end_to_end is running correctly in the test environment
daniel-sussman Aug 12, 2024
37cba6d
bugfix to true_up_spec
daniel-sussman Aug 13, 2024
34bc584
added some rake_helpers
daniel-sussman Aug 13, 2024
a24aa55
apply_to_job_spec mocks a user and user_detail
daniel-sussman Aug 13, 2024
4ff06f3
Bamboo is passing end_to_end tests
daniel-sussman Aug 13, 2024
8121f8d
disabled attach_resume in FactoryBot
daniel-sussman Aug 13, 2024
1944139
Bamboo yes_no question -> :radiogroup
daniel-sussman Aug 14, 2024
52ca4e5
re-activated FormFiller submit
daniel-sussman Aug 14, 2024
b2ae2e2
end_to_end raketask can handle more standard fields
daniel-sussman Aug 15, 2024
f43183a
WorkableFormFiller is working for most questions but not group type
daniel-sussman Aug 15, 2024
ba49e50
group questions managed up to stimulus controller
daniel-sussman Aug 16, 2024
864d082
problems with simple_form, group questions will break at template page
daniel-sussman Aug 16, 2024
755a674
very hacky version of group question is working for Workable
daniel-sussman Aug 17, 2024
0eebbc3
fixed Workable issue with group fields having same id as non-group fi…
daniel-sussman Aug 17, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/models/application_question.rb
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ def boolean_options

def field = fields.first

def locator = field['selector'] || "##{field['id']}"
def locator = field['selector'] || field['name']

def multi_checkbox?
type.eql?("checkbox") && (options&.count&.> 1)
Expand Down
5 changes: 4 additions & 1 deletion config/sidekiq.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,13 @@
cron: '0 1 * * *' # Runs once per day (at 1 am)
class: Updater::ExistingCompanyJobsJob
queue: updates
devitjobs_updater:
enabled: <%= Rails.env.production? %> # production only as it interferes with end-to-end testing
devitjobs_updater: # off temporarily as interferes with end-to-end testing
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How so?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain why this interferes and revert this in due course

cron: '0 2 * * *' # Runs once per day (at 2 am)
class: Importer::Api::DevitJobsJob
queue: updates
enabled: <%= Rails.env.production? %> # production only as it interferes with end-to-end testing
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similarly - why?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FormFiller runs as a background job. Can't run if there's three hundred background jobs already in the queue. Also it's just annoying in development to have the database constantly being filled with jobs I didn't seed.


# true_up_scraper: # off for now as we have already pulled all the ATS identifiers
# cron: '0 2 * * *' # Runs once per day (at 2 am)
# class: Importer::Scraper::TrueUpJob
Expand Down
33 changes: 33 additions & 0 deletions lib/tasks/testing.rake
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting approach - can we add some comments for how this should work

Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
namespace :testing do
desc "Conduct end-to-end tests on a given url"
task :url, [:url_string] => :environment do |_, args|
ENV['URL_FOR_TESTING'] = args[:url_string]

RSpec::Core::RakeTask.new(:spec_task) do |t|
t.pattern = 'spec/features/apply_to_job_spec.rb'
end

Rake::Task['spec_task'].invoke
end

# desc "Conduct end-to-end tests on a given url"
# task url: :environment do
# ENV['URL_FOR_TESTING'] = prompt_user

# RSpec::Core::RakeTask.new(:spec_task) do |t|
# t.pattern = 'spec/features/apply_to_job_spec.rb'
# end

# Rake::Task['spec_task'].invoke
# end

def prompt_user
response = nil
until response
puts "Please enter a valid job posting url:"
response = $stdin.gets.chomp
end

response
end
end
Loading
Loading