-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix application_question.locator for payload #227
base: main
Are you sure you want to change the base?
Changes from 3 commits
36f5852
f46f3f6
3c4660f
33aa52c
31268ac
74cdbfe
faef4c6
57d3224
39f7cdc
8710538
2a034ff
6dc9e26
aa402f4
616bc36
3c0e8ca
0b83b89
6f78152
0311e4e
a5ed9f5
bbb0591
e2c8167
55f92e7
eb5cbc0
0b012bb
33f16ec
32de85d
5083aa1
86404b3
bc0d676
2e37eda
673c2d4
37cba6d
34bc584
a24aa55
4ff06f3
8121f8d
1944139
52ca4e5
b2ae2e2
f43183a
ba49e50
864d082
755a674
0eebbc3
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -18,10 +18,13 @@ | |
cron: '0 1 * * *' # Runs once per day (at 1 am) | ||
class: Updater::ExistingCompanyJobsJob | ||
queue: updates | ||
devitjobs_updater: | ||
enabled: <%= Rails.env.production? %> # production only as it interferes with end-to-end testing | ||
devitjobs_updater: # off temporarily as interferes with end-to-end testing | ||
cron: '0 2 * * *' # Runs once per day (at 2 am) | ||
class: Importer::Api::DevitJobsJob | ||
queue: updates | ||
enabled: <%= Rails.env.production? %> # production only as it interferes with end-to-end testing | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Similarly - why? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. FormFiller runs as a background job. Can't run if there's three hundred background jobs already in the queue. Also it's just annoying in development to have the database constantly being filled with jobs I didn't seed. |
||
|
||
# true_up_scraper: # off for now as we have already pulled all the ATS identifiers | ||
# cron: '0 2 * * *' # Runs once per day (at 2 am) | ||
# class: Importer::Scraper::TrueUpJob | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Interesting approach - can we add some comments for how this should work |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,33 @@ | ||
namespace :testing do | ||
desc "Conduct end-to-end tests on a given url" | ||
task :url, [:url_string] => :environment do |_, args| | ||
ENV['URL_FOR_TESTING'] = args[:url_string] | ||
|
||
RSpec::Core::RakeTask.new(:spec_task) do |t| | ||
t.pattern = 'spec/features/apply_to_job_spec.rb' | ||
end | ||
|
||
Rake::Task['spec_task'].invoke | ||
end | ||
|
||
# desc "Conduct end-to-end tests on a given url" | ||
# task url: :environment do | ||
# ENV['URL_FOR_TESTING'] = prompt_user | ||
|
||
# RSpec::Core::RakeTask.new(:spec_task) do |t| | ||
# t.pattern = 'spec/features/apply_to_job_spec.rb' | ||
# end | ||
|
||
# Rake::Task['spec_task'].invoke | ||
# end | ||
|
||
def prompt_user | ||
response = nil | ||
until response | ||
puts "Please enter a valid job posting url:" | ||
response = $stdin.gets.chomp | ||
end | ||
|
||
response | ||
end | ||
end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How so?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you explain why this interferes and revert this in due course