Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stdlib sql return precision for DateTime64 #1469

Merged
merged 3 commits into from
Jan 13, 2025
Merged

stdlib sql return precision for DateTime64 #1469

merged 3 commits into from
Jan 13, 2025

Conversation

SpencerTorres
Copy link
Member

Summary

closes #1462

Checklist

Delete items not relevant to your PR:

  • Unit and integration tests covering the common scenarios were added

@SpencerTorres SpencerTorres requested a review from jkaflik January 10, 2025 02:46
jkaflik
jkaflik approved these changes Jan 13, 2025
View reviewed changes
Copy link
Contributor

@jkaflik jkaflik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tests/std/datetime64_test.go Outdated Show resolved Hide resolved
@SpencerTorres SpencerTorres merged commit d7cae99 into main Jan 13, 2025
@SpencerTorres SpencerTorres deleted the stdlib_datetime64_precision branch January 13, 2025 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkaflik jkaflik jkaflik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Database/SQL API missing Precision for type DateTime64
2 participants
@SpencerTorres @jkaflik