Fix #4351 : Reset Submission Type and Visibility on Challenge Submission #4473
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4473 +/- ##
==========================================
- Coverage 72.93% 69.35% -3.58%
==========================================
Files 83 20 -63
Lines 5368 3580 -1788
==========================================
- Hits 3915 2483 -1432
+ Misses 1453 1097 -356
... and 63 files with indirect coverage changes
... and 63 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Hey @PrasadCodesML , Can you please make sure that you are not changing any other lines in the codebase that are not required? Thanks!
| @@ -191,8 +191,7 @@ <h5 class="w-300">Make Submission</h5> | |||
| <p class="fs-18 w-400">Select phase:</p> | |||
| <ul> | |||
| <li ng-repeat="item in challenge.phases.results"> | |||
| <input | |||
| ng-disabled="challenge.currentDate < item.start_date || challenge.currentDate >= item.end_date" | |||
| <input ng-disabled="challenge.currentDate < item.start_date || challenge.currentDate >= item.end_date" | |||
There was a problem hiding this comment.
What is the change in this line?
There was a problem hiding this comment.
@RishabhJain2018 made the changes you suggested
…m:PrasadCodesML/EvalAI into BugFix/remove_submssion_type_marker_on_ui
This PR ensures that all submission-related fields are reset after a successful submission, preventing unintended carryover of values as mentioned in the issue #4351
Changes Introduced :
Reset submission-related values after submission in challengeCtrl.js:
phaseId, submissionType, submissionVisibility, and related flags (isSubmissionUsingCli, isSubmissionUsingFile, etc.) are now reset to default values.
Fixed submission type and visibility selection logic in submission.html:
Ensured radio buttons properly update the submissionType and submissionVisibility values.
Adjusted ng-click events to explicitly reset other submission options when one is selected.
Untitled.video.-.Made.with.Clipchamp.mp4